Commit graph

5 commits

Author SHA1 Message Date
WBHarry
cfb6bc2479 Fixed so that the forced critical toggle in the DamageDialog sets damageRoll.options.isCritical 2026-07-19 18:22:30 +02:00
WBHarry
c0fe127df4 Added overrides to modifierTotal and total getters in DamageRoll to addin critical damage when applicable 2026-07-19 17:24:53 +02:00
WBHarry
14edc7f4ca Fixed so that DamageRolls are actually stored with class='DamageRoll' in the chatMessage so they don't get instantiated as BaseRoll 2026-07-19 16:52:23 +02:00
WBHarry
863b5116f7 Initial 2026-07-19 16:33:07 +02:00
WBHarry
effab8db0c
[Rework] ChatMessage Damage (#2079)
Some checks are pending
Project CI / build (24.x) (push) Waiting to run
* Initial rework

* Removed unneeded method

* Removed outcommented code

* Added migration

* Fixed DamageActions

* Semi-corrected reroll of one of multiple results on a die

* Code improvement

* Added aseDie.rerollResult method to specifically reroll a specific result die in a grouping

* TagTeamDialog somewhat working

* Added migration for TagTeamData

* Fix for mean tagTeamDialog.finish

* .

* Improved migration

* Internalised ChatDamageData.prepareRolls to its own constructor

* Moved DamageTypes to roll.options

* TagTeamDialog fixes to accomodate new flat damage.types structure

* Changed so all default rolls become BaseRolls to access convenience functions and getters

* .

* Fixed so that party.tagTeam now uses a declared damageRollData(ChatDamageData) field. rollData.options.damage is retired.

* Critical damage fixes

* Corrected TagTeamDialog rerender logic when selecting a roll

* Fixed so that DamageTypes are retained and joined together throughout TagTeamDialog

* Removed some remaining types.<>.roll references

* [Rework] Damage and Damage Resource split (#2094)

* Changed the label of ActionSheet damage.resources to Mark Resources

* Fix assigning includeBase

* Localize add resource

* Maybe simplify API

* Fix onRollSimple

* Handle erroring action update differently

---------

Co-authored-by: Carlos Fernandez <cfern1990@gmail.com>
2026-07-19 03:02:57 +02:00