[Fix] 1535 - Toggle Bonuses (#1538)

* Fixed all SRD instances of Powerful and Massive

* Fixed suppressed effects being added to roll formula options

* Fixed weapon effects being presented when it's no the weapon itself

* .

* .

* Fixed secondary weapons effects

* Raised system version

* Update module/data/action/baseAction.mjs

Co-authored-by: Carlos Fernandez <CarlosFdez@users.noreply.github.com>

* Update module/documents/chatMessage.mjs

Co-authored-by: Carlos Fernandez <CarlosFdez@users.noreply.github.com>

---------

Co-authored-by: Carlos Fernandez <CarlosFdez@users.noreply.github.com>

module/applications/sheets/actors/character.mjs

@@ -712,7 +712,7 @@ export default class CharacterSheet extends DHBaseActorSheet {
             headerTitle: game.i18n.format('DAGGERHEART.UI.Chat.dualityRoll.abilityCheckTitle', {
                 ability: abilityLabel
             }),
-            effects: Array.from(await this.document.allApplicableEffects()),
+            effects: await await game.system.api.data.actions.actionsTypes.base.getEffects(this.document),
             roll: {
                 trait: button.dataset.attribute,
                 type: 'trait'

module/applications/sheets/api/application-mixin.mjs

@@ -505,7 +505,10 @@ export default function DHApplicationMixin(Base) {
                         const doc = await getDocFromElement(target),
                             action = doc?.system?.attack ?? doc;
                         const config = action.prepareConfig(event);
-                        config.effects = Array.from(await this.document.allApplicableEffects());
+                        config.effects = await game.system.api.data.actions.actionsTypes.base.getEffects(
+                            this.document,
+                            doc
+                        );
                         config.hasRoll = false;
                         return action && action.workflow.get('damage').execute(config, null, true);
                     }

module/data/action/baseAction.mjs

@@ -198,7 +198,7 @@ export default class DHBaseAction extends ActionMixin(foundry.abstract.DataModel
         let config = this.prepareConfig(event);
         if (!config) return;
 
-        await this.addEffects(config);
+        config.effects = await game.system.api.data.actions.actionsTypes.base.getEffects(this.actor, this.item);
 
         if (Hooks.call(`${CONFIG.DH.id}.preUseAction`, this, config) === false) return;
 
@@ -266,14 +266,26 @@ export default class DHBaseAction extends ActionMixin(foundry.abstract.DataModel
         return config;
     }
 
-    /** */
+    /**
-    async addEffects(config) {
+     * Get the all potentially applicable effects on the actor
-        let effects = [];
+     * @param {DHActor} actor The actor performing the action
-        if (this.actor) {
+     * @param {DHItem|DhActor} effectParent The parent of the effect
-            effects = Array.from(await this.actor.allApplicableEffects());
+     * @returns {DhActiveEffect[]}
-        }
+     */
+    static async getEffects(actor, effectParent) {
+        if (!actor) return [];
+        
+        return Array.from(await actor.allApplicableEffects()).filter(effect => {
+            /* Effects on weapons only ever apply for the weapon itself */
+            if (effect.parent.type === 'weapon') {
+                /* Unless they're secondary - then they apply only to other primary weapons */
+                if (effect.parent.system.secondary) {
+                    if (effectParent.type !== 'weapon' || effectParent.system.secondary) return false;
+                } else if (effectParent?.id !== effect.parent.id) return false;
+            }
 
-        config.effects = effects;
+            return !effect.isSuppressed;
+        });
     }
 
     /**

module/documents/chatMessage.mjs

@@ -158,7 +158,9 @@ export default class DhpChatMessage extends foundry.documents.ChatMessage {
         const config = foundry.utils.deepClone(this.system);
         config.event = event;
         if (this.system.action) {
-            await this.system.action.addEffects(config);
+            const actor = await foundry.utils.fromUuid(config.source.actor);
+            const item = actor?.items.get(config.source.item) ?? null;
+            config.effects = await game.system.api.data.actions.actionsTypes.base.getEffects(actor, item);
             await this.system.action.workflow.get('damage')?.execute(config, this._id, true);
         }
 

src/packs/items/weapons/weapon_Advanced_Greatstaff_4UzxqfkwF8gDSdu7.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "sGVVxSM68Fmr1sSM",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Advanced_Greatsword_MAC6YWTo4lzSotQc.json

@@ -118,16 +118,6 @@
           "key": "system.evasion",
           "mode": 2,
           "value": "-1"
-        },
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
         }
       ],
       "_id": "E0PjC15OP55vIype",

src/packs/items/weapons/weapon_Double_Flail_xm1yU7k58fMgXxRR.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "DCie5eR1dZH2Qvln",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Elder_Bow_JdWcn9W1edhAEInL.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "sZ1XotFlGdkPPDG4",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Floating_Bladeshards_3vti3xfo0wJND7ew.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "T831j6kZiMnpMNmv",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Gilded_Falchion_VwcOgqnzjf9LBj2S.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "ir4iKLIQ4CH1Qckn",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Greatbow_MXBpbqQsZFln4rZk.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "K4VgrDjVj1U1m9Ie",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Greatstaff_Yk8pTEmyLLi4095S.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "904orawScurM9GjG",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Greatsword_70ysaFJDREwTgvZa.json

@@ -118,16 +118,6 @@
           "key": "system.evasion",
           "mode": 2,
           "value": "-1"
-        },
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
         }
       ],
       "_id": "cffkpiwGpEGhjiUC",

src/packs/items/weapons/weapon_Improved_Greatstaff_LCuTrYXi4lhg6LqW.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "hnayB09P25ZW3gVY",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Improved_Greatsword_FPX4ouDrxXiQ5MDf.json

@@ -118,16 +118,6 @@
           "key": "system.evasion",
           "mode": 2,
           "value": "-1"
-        },
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
         }
       ],
       "_id": "2nl35v8sPAudiOIb",

src/packs/items/weapons/weapon_Legendary_Greatstaff_jDtvEabkHY1GFgfc.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "OV1Ly7vX4owBUgLQ",
       "type": "base",
       "system": {},

src/packs/items/weapons/weapon_Legendary_Greatsword_zMZ46F9VR7zdTxb9.json

@@ -118,16 +118,6 @@
           "key": "system.evasion",
           "mode": 2,
           "value": "-1"
-        },
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
         }
       ],
       "_id": "oRCiXSElN5xufUfn",

src/packs/items/weapons/weapon_Mage_Orb_XKBmBUEoGLdLcuqQ.json

@@ -113,18 +113,7 @@
       "name": "Powerful",
       "description": "On a successful attack, roll an additional damage die and discard the lowest result.",
       "img": "icons/magic/control/buff-flight-wings-runes-red-yellow.webp",
-      "changes": [
+      "changes": [],
-        {
-          "key": "system.bonuses.damage.primaryWeapon.extraDice",
-          "mode": 2,
-          "value": "1"
-        },
-        {
-          "key": "system.rules.weapon.dropLowestDamageDice",
-          "mode": 5,
-          "value": "1"
-        }
-      ],
       "_id": "2J6vzNUel78JFypp",
       "type": "base",
       "system": {},