mirror of
https://github.com/Foundryborne/daggerheart.git
synced 2026-04-22 15:33:37 +02:00
Fix Include Item Damage error in v14 damage system
- Change behavior from 'Include Item Damage' to 'Use Item Damage' - Replace action damage with weapon base damage instead of unshift - Fixes error where unshift fails due to v14 single damage instance limit - Update label to reflect new behavior Fixes Foundryborne/daggerheart#1794 Signed-off-by: codebytaki <codebytaki@users.noreply.github.com>
This commit is contained in:
parent
94f1fbdd9b
commit
6afc5d625a
4 changed files with 87 additions and 22 deletions
46
.github/PULL_REQUEST_TEMPLATE.md
vendored
Normal file
46
.github/PULL_REQUEST_TEMPLATE.md
vendored
Normal file
|
|
@ -0,0 +1,46 @@
|
|||
## Description
|
||||
|
||||
<!-- Provide a brief description of what this PR does -->
|
||||
|
||||
## Type of Change
|
||||
|
||||
<!-- Check all that apply -->
|
||||
|
||||
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
|
||||
- [ ] ✨ New feature (non-breaking change which adds functionality)
|
||||
- [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
||||
- [ ] 📝 Documentation update
|
||||
- [ ] 🎨 UI/UX improvement
|
||||
- [ ] 🔧 Code refactoring
|
||||
- [ ] ⚡ Performance improvement
|
||||
|
||||
## Testing
|
||||
|
||||
<!-- Describe the tests you ran and how to reproduce them -->
|
||||
|
||||
- [ ] I have tested this locally in Foundry VTT
|
||||
- [ ] All existing tests pass
|
||||
- [ ] I have added tests that prove my fix is effective or that my feature works
|
||||
|
||||
## Screenshots (if applicable)
|
||||
|
||||
<!-- Add screenshots or GIFs to demonstrate UI/UX changes -->
|
||||
|
||||
## Checklist
|
||||
|
||||
- [ ] My code follows the project's style guidelines
|
||||
- [ ] I have performed a self-review of my code
|
||||
- [ ] I have commented my code, particularly in hard-to-understand areas
|
||||
- [ ] I have made corresponding changes to the documentation
|
||||
- [ ] My changes generate no new warnings
|
||||
- [ ] Any dependent changes have been merged and published
|
||||
|
||||
## Related Issues
|
||||
|
||||
<!-- Link any related issues using #issue-number -->
|
||||
|
||||
Fixes #
|
||||
|
||||
## Additional Notes
|
||||
|
||||
<!-- Add any other context about the PR here -->
|
||||
Loading…
Add table
Add a link
Reference in a new issue