lang/en.json

@@ -2010,8 +2010,7 @@
             "Attachments": {
                 "attachHint": "Drop items here to attach them",
                 "transferHint": "If checked, this effect will be applied to any actor that owns this Effect's parent Item. The effect is always applied if this Item is attached to another one."
-            },
+            }
-            "OriginTag": "Origin: {name}"
         },
         "GENERAL": {
             "Ability": {

module/data/action/baseAction.mjs

@@ -348,31 +348,29 @@ export default class DHBaseAction extends ActionMixin(foundry.abstract.DataModel
             'system.bonuses.roll.spellcast.bonus'
         ];
 
-        const results = [];
+        return Array.from(await actor.allApplicableEffects({ noTransferArmor: true, noSelfArmor: true })).reduce(
-        const applicableEffects = await actor.allApplicableEffects({ noTransferArmor: true, noSelfArmor: true });
+            (acc, effect) => {
-        for (const effect of [...applicableEffects].filter(e => !e.isSuppressed)) {
+                const effectData = effect.toObject();
-            if (effect.parent.type === 'weapon') {
+                /* Effects on weapons only ever apply for the weapon itself, with a few defined exceptions */
-                // Effects on weapons only ever apply for the weapon itself (with a few exceptions)
+                if (effect.parent.type === 'weapon') {
-                const restricted =
+                    /* Unless they're secondary - then they apply only to other primary weapons */
-                    effect.parent.system.secondary
+                    if (effect.parent.system.secondary) {
-                        // Secondary applies only to other primary weapons
+                        if (effectParent?.type !== 'weapon' || effectParent?.system.secondary) {
-                        ? effectParent?.type !== 'weapon' || effectParent?.system.secondary
+                            effectData.system.changes = 
-                        // Primary only applies to itself
+                                effectData.system.changes.filter(x => weaponTransferredEffectKeys.includes(x.key));
-                        : effectParent?.id !== effect.parent.id;
+                        } 
-                if (restricted) {
+                    } else if (effectParent?.id !== effect.parent.id) {
-                    const sourceChanges = effect._source.system.changes;
+                        effectData.system.changes = 
-                    const changes = sourceChanges.filter(x => weaponTransferredEffectKeys.includes(x.key));
+                            effectData.system.changes.filter(x => weaponTransferredEffectKeys.includes(x.key));
-                    if (changes.length) {
-                        results.push(effect.clone({ 'system.changes': changes }));
                     }
-                    continue;
                 }
-            }
-                
-            results.push(effect);
-        }
 
-        return results;
+                if (!effect.isSuppressed) {
+                    acc.push(effectData);
+                }
+
+                return acc;
+            }, []);
     }
 
     /**

module/documents/activeEffect.mjs

@@ -224,13 +224,12 @@ export default class DhActiveEffect extends foundry.documents.ActiveEffect {
      * @returns {string[]} An array of localized tag strings.
      */
     _getTags() {
-        const tags = [];
+        const tags = [
-        const originActor = DhActiveEffect.#resolveParentDocument(fromUuidSync(this.origin, { strict: false }), Actor);
+            `${game.i18n.localize(this.parent.system.metadata.label)}: ${this.parent.name}`,
-        if (originActor && originActor !== this.actor) {
+            game.i18n.localize(
-            tags.push(_loc('DAGGERHEART.EFFECTS.OriginTag', { name: originActor.name }));
+                this.isTemporary ? 'DAGGERHEART.EFFECTS.Duration.temporary' : 'DAGGERHEART.EFFECTS.Duration.passive'
-        } else if (!(this.parent instanceof Actor)) {
+            )
-            tags.push(`${_loc(this.parent.system.metadata.label)}: ${this.parent.name}`);
+        ];
-        }
 
         for (const statusId of this.statuses) {
             const status = CONFIG.statusEffects.find(s => s.id === statusId);

module/documents/combat.mjs

@@ -46,9 +46,7 @@ export default class DhpCombat extends Combat {
             for (let actor of actors) {
                 await actor.createEmbeddedDocuments(
                     'ActiveEffect',
-                    effects
+                    effects.filter(x => x.effectTargetTypes.includes(actor.type))
-                        .filter(x => x.effectTargetTypes.includes(actor.type))
-                        .map(x => foundry.utils.deepClone(x))
                 );
             }
         } else {

styles/less/global/prose-mirror.less

@@ -3,8 +3,6 @@
 
 .application.daggerheart {
     prose-mirror {
-        --menu-padding: 4px 0px;
-        --menu-height: calc(var(--menu-button-height) + 8px);
         height: 100% !important;
         width: 100%;
 

system.json

@@ -2,7 +2,7 @@
     "id": "daggerheart",
     "title": "Daggerheart",
     "description": "An unofficial implementation of the Daggerheart system",
-    "version": "2.4.1",
+    "version": "2.4.0",
     "compatibility": {
         "minimum": "14.364",
         "verified": "14.364",
@@ -10,7 +10,7 @@
     },
     "url": "https://github.com/Foundryborne/daggerheart",
     "manifest": "https://raw.githubusercontent.com/Foundryborne/daggerheart/v14/system.json",
-    "download": "https://github.com/Foundryborne/daggerheart/releases/download/2.4.1/system.zip",
+    "download": "https://github.com/Foundryborne/daggerheart/releases/download/2.4.0/system.zip",
     "authors": [
         {
             "name": "WBHarry"