Fixed onCreate and preDelete

Co-authored-by: Carlos Fernandez <CarlosFdez@users.noreply.github.com>

module/applications/sidebar/tabs/actorDirectory.mjs

@@ -102,11 +102,7 @@ export default class DhActorDirectory extends foundry.applications.sidebar.tabs.
                     const actor = game.actors.get(li.dataset.entryId);
                     if (!actor) throw new Error('Unexpected missing actor');
 
-                    const currentActiveParty = game.actors.find(x => x.type === 'party' && x.system.active);
+                    await game.settings.set(CONFIG.DH.id, CONFIG.DH.SETTINGS.gameSettings.ActiveParty, actor.id);
-                    if (currentActiveParty)
-                        await currentActiveParty.update({ 'system.active': false });
-
-                    await actor.update({ 'system.active': true });
                     ui.actors.render();
                 }
             }

module/config/settingsConfig.mjs

@@ -40,7 +40,8 @@ export const gameSettings = {
     LastMigrationVersion: 'LastMigrationVersion',
     SpotlightRequestQueue: 'SpotlightRequestQueue',
     CompendiumBrowserSettings: 'CompendiumBrowserSettings',
-    SpotlightTracker: 'SpotlightTracker'
+    SpotlightTracker: 'SpotlightTracker',
+    ActiveParty: 'ActiveParty',
 };
 
 export const actionAutomationChoices = {

module/data/actor/party.mjs

@@ -9,7 +9,6 @@ export default class DhParty extends BaseDataActor {
         const fields = foundry.data.fields;
         return {
             ...super.defineSchema(),
-            active: new fields.BooleanField(),
             partyMembers: new ForeignDocumentUUIDArrayField({ type: 'Actor' }, { prune: true }),
             notes: new fields.HTMLField(),
             gold: new fields.SchemaField({
@@ -23,6 +22,10 @@ export default class DhParty extends BaseDataActor {
         };
     }
 
+    get active() {
+        return game.settings.get(CONFIG.DH.id, CONFIG.DH.SETTINGS.gameSettings.ActiveParty) === this.parent.id;
+    }
+
     /* -------------------------------------------- */
 
     /**@inheritdoc */
@@ -45,13 +48,21 @@ export default class DhParty extends BaseDataActor {
         }
     }
 
-    /**@inheritdoc */
+    _onCreate(data, options, userId) {
-    async _preCreate(data, options, user) {
+        super._onCreate(data, options, userId);
-        const allowed = await super._preCreate(data, options, user);
-        if (allowed === false) return;
 
-        if (!game.actors.some(x => x.type === 'party' && x.active)) 
+        if (game.user.isActiveGM && !game.settings.get(CONFIG.DH.id, CONFIG.DH.SETTINGS.gameSettings.ActiveParty)) {
-            await this.updateSource({ active: true });
+            game.settings.set(CONFIG.DH.id, CONFIG.DH.SETTINGS.gameSettings.ActiveParty, this.parent.id).then(_ => {
+                ui.actors.render();
+            });
+        }
+    }
+
+    async _preDelete() {
+        super._preDelete();
+    
+        if (this.active) 
+            game.settings.set(CONFIG.DH.id, CONFIG.DH.SETTINGS.gameSettings.ActiveParty, null);
     }
 
     _onDelete(options, userId) {

module/documents/actor.mjs

@@ -125,6 +125,8 @@ export default class DhpActor extends Actor {
                 game.system.registeredTriggers.unregisterItemTriggers(token.actor.items);
             }
         }
+
+        if(this.system._preDelete() === false) return false;
     }
 
     _onDelete(options, userId) {

module/systemRegistration/settings.mjs

@@ -189,4 +189,11 @@ const registerNonConfigSettings = () => {
         config: false,
         type: SpotlightTracker
     });
+
+    game.settings.register(CONFIG.DH.id, CONFIG.DH.SETTINGS.gameSettings.ActiveParty, {
+        scope: 'world',
+        config: false,
+        type: String,
+        default: null,
+    });
 };