This commit is contained in:
WBHarry 2026-02-09 19:38:29 +01:00
parent 514e0260eb
commit fb9f89fa9d
8 changed files with 127 additions and 57 deletions

View file

@ -1,3 +1,7 @@
/**
* ArmorEffects are ActiveEffects that have a static changes field of length 1. It includes current and maximum armor.
* When applied to a character, it adds to their currently marked and maximum armor.
*/
export default class ArmorEffect extends foundry.data.ActiveEffectTypeDataModel {
static defineSchema() {
const fields = foundry.data.fields;
@ -14,7 +18,7 @@ export default class ArmorEffect extends foundry.data.ActiveEffectTypeDataModel
}),
phase: new fields.StringField({ required: true, blank: false, initial: 'initial' }),
priority: new fields.NumberField({ integer: true, initial: 20 }),
marked: new fields.NumberField({
value: new fields.NumberField({
required: true,
integer: true,
initial: 0,
@ -28,28 +32,35 @@ export default class ArmorEffect extends foundry.data.ActiveEffectTypeDataModel
min: 1,
label: 'DAGGERHEART.GENERAL.max'
})
})
}),
{
initial: [
{
type: CONFIG.DH.GENERAL.activeEffectModes.armor.id,
phase: 'initial',
priority: 20,
value: 0,
max: 1
}
]
}
)
};
}
get armorData() {
if (this.changes.length !== 1) return { value: 0, max: 0 };
return { value: this.changes[0].value, max: this.changes[0].max };
}
/* Type Functions */
async updateArmorMax(newMax) {
if (this.changes.length !== 1) return;
const newChanges = this.changes.map(change => ({
...change,
max: newMax,
marked: Math.min(change.marked, newMax)
}));
await this.parent.update({ 'system.changes': newChanges });
}
/**
* Validate that an {@link EffectChangeData#type} string is well-formed.
* @param {string} type The string to be validated
* @returns {true}
* @throws {Error} An error if the type string is malformed
*/
static #validateType(type) {
if (type !== CONFIG.DH.GENERAL.activeEffectModes.armor.id)
throw new Error('An armor effect must have change.type "armor"');
static applyChangeField(model, change, field) {
return [model, change, field];
return true;
}
static armorChangeEffect = {
@ -81,23 +92,71 @@ export default class ArmorEffect extends foundry.data.ActiveEffectTypeDataModel
render: null
};
/* Helpers */
get armorChange() {
if (this.changes.length !== 1)
throw new Error('Unexpected error. An armor effect should have a changes field of length 1.');
return this.changes[0];
}
get armorData() {
return { value: this.armorChange.value, max: this.armorChange.max };
}
async updateArmorMax(newMax) {
const newChanges = [
{
...this.armorChange,
max: newMax,
value: Math.min(this.armorChange.value, newMax)
}
];
await this.parent.update({ 'system.changes': newChanges });
}
/* Overrides */
prepareBaseData() {
for (const change of this.changes) {
change.key = 'system.armorScore';
change.value = Math.min(change.max - change.marked, change.max);
const armorChange = this.armorChange;
armorChange.key = 'system.armorScore';
}
static getDefaultEffectData() {
return {
type: 'armor',
name: game.i18n.localize('DAGGERHEART.EFFECTS.Armor.newArmorEffect'),
img: 'icons/equipment/chest/breastplate-helmet-metal.webp'
};
}
async _preCreate(data, options, user) {
const allowed = await super._preCreate(data, options, user);
if (allowed === false) return;
await this.updateSource({ ...ArmorEffect.getDefaultEffectData(), data });
}
async _preUpdate(changes, options, user) {
const allowed = await super._preUpdate(changes, options, user);
if (allowed === false) return false;
if (changes.system?.changes) {
const changesChanged = changes.system.changes.length !== this.changes.length;
if (changesChanged) {
ui.notifications.error(
game.i18n.localize('DAGGERHEART.UI.Notifications.cannotAlterArmorEffectChanges')
);
return false;
}
if (
changes.system.changes.length === 1 &&
changes.system.changes[0].type !== CONFIG.DH.GENERAL.activeEffectModes.armor.id
) {
ui.notifications.error(game.i18n.localize('DAGGERHEART.UI.Notifications.cannotAlterArmorEffectType'));
return false;
}
}
}
/**
* Validate that an {@link EffectChangeData#type} string is well-formed.
* @param {string} type The string to be validated
* @returns {true}
* @throws {Error} An error if the type string is malformed
*/
static #validateType(type) {
if (type !== CONFIG.DH.GENERAL.activeEffectModes.armor.id)
throw new Error('An armor effect must have change.type "armor"');
return true;
}
}

View file

@ -458,6 +458,11 @@ export default class DhCharacter extends BaseDataActor {
return this.parent.items.find(x => x.type === 'armor' && x.system.equipped);
}
/* TODO: Prep datastructure to be useful when applying automatic armor damage order */
get armorEffects() {
return Array.from(this.parent.allApplicableEffects());
}
get activeBeastform() {
return this.parent.effects.find(x => x.type === 'beastform');
}

View file

@ -54,10 +54,16 @@ export default class DHArmor extends AttachableItem {
}
get armorEffect() {
/* TODO: make armors only able to have on armor effect, or handle in some other way */
return this.parent.effects.find(x => x.type === 'armor');
}
get armorData() {
const armorEffect = this.armorEffect;
if (!armorEffect) return { value: 0, max: 0 };
return armorEffect.system.armorData;
}
/**@inheritdoc */
async getDescriptionData() {
const baseDescription = this.description;
@ -73,6 +79,17 @@ export default class DHArmor extends AttachableItem {
return { prefix, value: baseDescription, suffix: null };
}
/**@inheritdoc */
async _onCreate(_data, _options, userId) {
if (userId !== game.user.id) return;
if (!this.parent.effects.some(x => x.type === 'armor')) {
this.parent.createEmbeddedDocuments('ActiveEffect', [
game.system.api.data.activeEffects.ArmorEffect.getDefaultEffectData()
]);
}
}
/**@inheritdoc */
async _preUpdate(changes, options, user) {
const allowed = await super._preUpdate(changes, options, user);
@ -163,9 +180,8 @@ export default class DHArmor extends AttachableItem {
* @returns {string[]} An array of localized tag strings.
*/
_getTags() {
const baseScore = this.armorEffect?.system.armorData?.value;
const tags = [
`${game.i18n.localize('DAGGERHEART.ITEMS.Armor.baseScore')}: ${baseScore}`,
`${game.i18n.localize('DAGGERHEART.ITEMS.Armor.baseScore')}: ${this.armorData.value}`,
`${game.i18n.localize('DAGGERHEART.ITEMS.Armor.baseThresholds.base')}: ${this.baseThresholds.major} / ${this.baseThresholds.severe}`
];
@ -177,11 +193,7 @@ export default class DHArmor extends AttachableItem {
* @returns {(string | { value: string, icons: string[] })[]} An array of localized strings and damage label objects.
*/
_getLabels() {
const labels = [];
if (this.armorEffect)
labels.push(
`${game.i18n.localize('DAGGERHEART.ITEMS.Armor.baseScore')}: ${this.armorEffect.system.armorData?.value}`
);
const labels = [`${game.i18n.localize('DAGGERHEART.ITEMS.Armor.baseScore')}: ${this.armorData.value}`];
return labels;
}