From e06aac3315ef2fb6ada7a90828d6459ec2e3ff73 Mon Sep 17 00:00:00 2001
From: moliloo <dev.murilobrito@gmail.com>
Date: Sat, 5 Jul 2025 14:30:58 -0300
Subject: [PATCH] enhance advantage logic

---
 module/applications/dialogs/d20RollDialog.mjs | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/module/applications/dialogs/d20RollDialog.mjs b/module/applications/dialogs/d20RollDialog.mjs
index c23915db..7eaeacb3 100644
--- a/module/applications/dialogs/d20RollDialog.mjs
+++ b/module/applications/dialogs/d20RollDialog.mjs
@@ -107,14 +107,8 @@ export default class D20RollDialog extends HandlebarsApplicationMixin(Applicatio
 
     static updateIsAdvantage(_, button) {
         const advantage = Number(button.dataset.advantage);
-        if (advantage === 1) {
-            this.advantage = true;
-            this.disadvantage = false;
-        }
-        if (advantage === -1) {
-            this.advantage = false;
-            this.disadvantage = true;
-        }
+        this.advantage = advantage === 1;
+        this.disadvantage = advantage === -1;
 
         this.config.roll.advantage = this.config.roll.advantage === advantage ? 0 : advantage;
         this.render();