From d24fef7494da497e8d94245287a43849c61a29c5 Mon Sep 17 00:00:00 2001
From: WBHarry <89362246+WBHarry@users.noreply.github.com>
Date: Sun, 24 Aug 2025 19:15:42 +0200
Subject: [PATCH] [Fix] Hints For Drag/Drop (#1076)

* Added hints for drag-drop areas

* Changed to drag-area style. Updated localization
---
 lang/en.json                                      |  5 +++++
 styles/less/global/global.less                    | 12 ++++++++++++
 styles/less/global/index.less                     |  1 +
 .../environment-settings/adversaries.less         | 13 -------------
 .../less/sheets/actors/character/inventory.less   |  4 ----
 styles/less/sheets/actors/character/loadout.less  |  4 ----
 styles/less/ui/item-browser/item-browser.less     |  8 ++------
 .../environment-settings/adversaries.hbs          |  2 +-
 templates/sheets/items/class/features.hbs         |  3 +++
 templates/sheets/items/class/settings.hbs         | 15 +++++++++++++++
 10 files changed, 39 insertions(+), 28 deletions(-)
 create mode 100644 styles/less/global/global.less

diff --git a/lang/en.json b/lang/en.json
index f310a01d..7efca151 100755
--- a/lang/en.json
+++ b/lang/en.json
@@ -1894,6 +1894,7 @@
             "amount": "Amount",
             "any": "Any",
             "armor": "Armor",
+            "armors": "Armors",
             "armorScore": "Armor Score",
             "activeEffects": "Active Effects",
             "armorSlots": "Armor Slots",
@@ -1944,6 +1945,7 @@
             "inactiveEffects": "Inactive Effects",
             "inventory": "Inventory",
             "itemResource": "Item Resource",
+            "items": "Items",
             "label": "Label",
             "level": "Level",
             "levelShort": "Lv",
@@ -1955,6 +1957,7 @@
                 "plural": "Miss"
             },
             "maxWithThing": "Max {thing}",
+            "missingDragDropThing": "Drop {thing} here",
             "multiclass": "Multiclass",
             "newCategory": "New Category",
             "none": "None",
@@ -1976,6 +1979,7 @@
             "scalable": "Scalable",
             "situationalBonus": "Situational Bonus",
             "stress": "Stress",
+            "subclasses": "Subclasses",
             "success": "Success",
             "take": "Take",
             "Target": {
@@ -1993,6 +1997,7 @@
             "used": "Used",
             "uses": "Uses",
             "value": "Value",
+            "weapons": "Weapons",
             "withThing": "With {thing}"
         },
         "ITEMS": {
diff --git a/styles/less/global/global.less b/styles/less/global/global.less
new file mode 100644
index 00000000..5bf32746
--- /dev/null
+++ b/styles/less/global/global.less
@@ -0,0 +1,12 @@
+.drag-area {
+    display: flex;
+    align-items: center;
+    justify-content: center;
+    box-sizing: border-box;
+    width: 100%;
+    height: 40px;
+    border: 1px dashed light-dark(@dark-blue-50, @beige-50);
+    border-radius: 3px;
+    color: light-dark(@dark-blue-50, @beige-50);
+    font-family: @font-body;
+}
diff --git a/styles/less/global/index.less b/styles/less/global/index.less
index 5f955ce3..db61304a 100644
--- a/styles/less/global/index.less
+++ b/styles/less/global/index.less
@@ -3,6 +3,7 @@
 @import './chat.less';
 @import './elements.less';
 @import './enrichment.less';
+@import './global.less';
 @import './tab-navigation.less';
 @import './tab-form-footer.less';
 @import './tab-actions.less';
diff --git a/styles/less/sheets-settings/environment-settings/adversaries.less b/styles/less/sheets-settings/environment-settings/adversaries.less
index 8dc12c87..1a27eaca 100644
--- a/styles/less/sheets-settings/environment-settings/adversaries.less
+++ b/styles/less/sheets-settings/environment-settings/adversaries.less
@@ -34,18 +34,5 @@
                 width: 100%;
             }
         }
-
-        .adversaries-dragger {
-            display: flex;
-            align-items: center;
-            justify-content: center;
-            box-sizing: border-box;
-            width: 100%;
-            height: 40px;
-            border: 1px dashed light-dark(@dark-blue-50, @beige-50);
-            border-radius: 3px;
-            color: light-dark(@dark-blue-50, @beige-50);
-            font-family: @font-body;
-        }
     }
 }
diff --git a/styles/less/sheets/actors/character/inventory.less b/styles/less/sheets/actors/character/inventory.less
index 48bdd682..d8c225ad 100644
--- a/styles/less/sheets/actors/character/inventory.less
+++ b/styles/less/sheets/actors/character/inventory.less
@@ -27,10 +27,6 @@
                         outline: 2px solid light-dark(@dark, @golden);
                     }
 
-                    &:placeholder {
-                        color: light-dark(@dark-blue-50, @beige-50);
-                    }
-
                     &::-webkit-search-cancel-button {
                         -webkit-appearance: none;
                         display: none;
diff --git a/styles/less/sheets/actors/character/loadout.less b/styles/less/sheets/actors/character/loadout.less
index 98fe9eed..24a53959 100644
--- a/styles/less/sheets/actors/character/loadout.less
+++ b/styles/less/sheets/actors/character/loadout.less
@@ -27,10 +27,6 @@
                         outline: 2px solid light-dark(@dark, @golden);
                     }
 
-                    &:placeholder {
-                        color: light-dark(@dark-blue-50, @beige-50);
-                    }
-
                     &::-webkit-search-cancel-button {
                         -webkit-appearance: none;
                         display: none;
diff --git a/styles/less/ui/item-browser/item-browser.less b/styles/less/ui/item-browser/item-browser.less
index 407a3116..7d708e1f 100644
--- a/styles/less/ui/item-browser/item-browser.less
+++ b/styles/less/ui/item-browser/item-browser.less
@@ -148,10 +148,6 @@
                             outline: 2px solid light-dark(@dark, @golden);
                         }
 
-                        &:placeholder {
-                            color: light-dark(@dark-blue-50, @beige-50);
-                        }
-
                         &::-webkit-search-cancel-button {
                             -webkit-appearance: none;
                             display: none;
@@ -187,7 +183,7 @@
                 }
 
                 &:has(+ .subfolder-list):after {
-                    content: "+";
+                    content: '+';
                 }
             }
 
@@ -357,7 +353,7 @@
             grid-template-rows: 0fr;
             transition: all 0.3s ease-in-out;
             width: 100%;
-            
+
             .wrapper {
                 overflow: hidden;
                 display: grid;
diff --git a/templates/sheets-settings/environment-settings/adversaries.hbs b/templates/sheets-settings/environment-settings/adversaries.hbs
index 3464a745..4d8b5122 100644
--- a/templates/sheets-settings/environment-settings/adversaries.hbs
+++ b/templates/sheets-settings/environment-settings/adversaries.hbs
@@ -25,7 +25,7 @@
             </div>
             {{/each}}
         </div>
-        <div class="adversaries-dragger">
+        <div class="drag-area">
             {{localize "DAGGERHEART.GENERAL.dropActorsHere"}}
         </div>
     </fieldset>
diff --git a/templates/sheets/items/class/features.hbs b/templates/sheets/items/class/features.hbs
index 4e6a7e6f..6ed449dc 100644
--- a/templates/sheets/items/class/features.hbs
+++ b/templates/sheets/items/class/features.hbs
@@ -27,6 +27,9 @@
         <fieldset>
             <legend>{{localize "TYPES.Item.subclass"}}</legend>
             <div class="feature-list">
+                {{#unless source.system.subclasses}}
+                    <div class="drag-area">{{localize "DAGGERHEART.GENERAL.missingDragDropThing" thing=(localize "DAGGERHEART.GENERAL.subclasses")}}</div>
+                {{/unless}}
                 {{#each source.system.subclasses as |subclass index|}}
                     <li class='feature-item'>
                         <div class='feature-line'>
diff --git a/templates/sheets/items/class/settings.hbs b/templates/sheets/items/class/settings.hbs
index 9ac2b14f..8e8254ee 100644
--- a/templates/sheets/items/class/settings.hbs
+++ b/templates/sheets/items/class/settings.hbs
@@ -45,6 +45,8 @@
                                 {{#unless (eq document.parent.type 'character')}}<a data-action="removeSuggestedItem" data-target="suggestedPrimaryWeapon"><i class="fa-solid fa-trash icon-button"></i></a>{{/unless}}
                             </div>
                         </div>
+                    {{else}}
+                        <div class="drag-area">{{localize "DAGGERHEART.GENERAL.missingDragDropThing" thing=(localize "DAGGERHEART.GENERAL.weapons")}}</div>
                     {{/if}}
                 </div>
             </fieldset>
@@ -60,6 +62,8 @@
                                 {{#unless (eq document.parent.type 'character')}}<a data-action="removeSuggestedItem" data-target="suggestedSecondaryWeapon"><i class="fa-solid fa-trash icon-button"></i></a>{{/unless}}
                             </div>
                         </div>
+                    {{else}}
+                        <div class="drag-area">{{localize "DAGGERHEART.GENERAL.missingDragDropThing" thing=(localize "DAGGERHEART.GENERAL.weapons")}}</div>
                     {{/if}}
                 </div>
             </fieldset>
@@ -75,6 +79,8 @@
                                 {{#unless (eq document.parent.type 'character')}}<a data-action="removeSuggestedItem" data-target="suggestedArmor"><i class="fa-solid fa-trash icon-button"></i></a>{{/unless}}
                             </div>
                         </div>
+                    {{else}}
+                        <div class="drag-area">{{localize "DAGGERHEART.GENERAL.missingDragDropThing" thing=(localize "DAGGERHEART.GENERAL.armors")}}</div>
                     {{/if}}
                 </div>
             </fieldset>
@@ -85,6 +91,9 @@
             <fieldset class="one-column drop-section take-section {{#if (eq document.parent.type 'character')}}inactive{{/if}}">
                 <legend>{{localize "DAGGERHEART.GENERAL.take"}}</legend>
                 <div class="drop-section-body list-items">
+                    {{#unless source.system.inventory.take}}
+                        <div class="drag-area">{{localize "DAGGERHEART.GENERAL.missingDragDropThing" thing=(localize "DAGGERHEART.GENERAL.items")}}</div>
+                    {{/unless}}
                     {{#each source.system.inventory.take}}
                         {{#if this}}
                             <div class="suggested-item item-line" data-action="editDoc" data-item-uuid="{{this.uuid}}">
@@ -102,6 +111,9 @@
             <fieldset class="one-column drop-section choice-a-section {{#if (eq document.parent.type 'character')}}inactive{{/if}}">
                 <legend>{{localize "DAGGERHEART.ITEMS.Class.guide.inventory.thenChoose"}}</legend>
                 <div class="drop-section-body list-items">
+                    {{#unless source.system.inventory.choiceA}}
+                        <div class="drag-area">{{localize "DAGGERHEART.GENERAL.missingDragDropThing" thing=(localize "DAGGERHEART.GENERAL.items")}}</div>
+                    {{/unless}}
                     {{#each source.system.inventory.choiceA}}
                         {{#if this}}
                             <div class="suggested-item item-line" data-action="editDoc" data-item-uuid="{{this.uuid}}">
@@ -119,6 +131,9 @@
             <fieldset class="one-column drop-section choice-b-section {{#if (eq document.parent.type 'character')}}inactive{{/if}}">
                 <legend>{{localize "DAGGERHEART.ITEMS.Class.guide.inventory.andEither"}}</legend>
                 <div class="drop-section-body list-items">
+                    {{#unless source.system.inventory.choiceB}}
+                        <div class="drag-area">{{localize "DAGGERHEART.GENERAL.missingDragDropThing" thing=(localize "DAGGERHEART.GENERAL.items")}}</div>
+                    {{/unless}}
                     {{#each source.system.inventory.choiceB}}
                         {{#if this}}
                             <div class="suggested-item item-line" data-action="editDoc" data-item-uuid="{{this.uuid}}">