From a7c4549e6f8ded87478a8be9f73fe474f8101b82 Mon Sep 17 00:00:00 2001 From: Carlos Fernandez Date: Mon, 30 Mar 2026 22:10:41 -0400 Subject: [PATCH] Add more caution to the dualityRoll fromData function --- module/dice/dualityRoll.mjs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/module/dice/dualityRoll.mjs b/module/dice/dualityRoll.mjs index f4cdeba2..291b8995 100644 --- a/module/dice/dualityRoll.mjs +++ b/module/dice/dualityRoll.mjs @@ -142,9 +142,9 @@ export default class DualityRoll extends D20Roll { static fromData(data) { data.terms[0].class = 'DualityDie'; data.terms[2].class = 'DualityDie'; - - if (data.options.roll.advantage?.type === 1) data.terms[4].class = 'AdvantageDie'; - else if (data.options.roll.advantage?.type === -1) data.terms[4].class = 'DisadvantageDie'; + if (data.options.roll.advantage?.type && data.terms[4]?.faces) { + data.terms[4].class = data.options.roll.advantage.type === 1 ? 'AdvantageDie' : 'DisadvantageDie'; + } return super.fromData(data); }