Enable no unused vars and add more types (#2005)
Some checks failed
Project CI / build (24.x) (push) Has been cancelled

This commit is contained in:
Carlos Fernandez 2026-06-14 16:10:49 -04:00 committed by GitHub
parent af49c1f4c8
commit 96f090bef5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
20 changed files with 141 additions and 31 deletions

22
module/documents/_types.d.ts vendored Normal file
View file

@ -0,0 +1,22 @@
import BaseDataActor from '../data/actor/base.mjs'
import DHItem from './item.mjs';
import BaseDataItem from '../data/item/base.mjs';
import DhActiveEffect from './activeEffect.mjs';
import EmbeddedCollection from '@common/abstract/embedded-collection.mjs';
declare module './actor.mjs' {
export default interface DhpActor<T extends BaseDataActor = BaseDataActor> {
system: T;
items: EmbeddedCollection<DHItem>;
effects: EmbeddedCollection<DhActiveEffect>;
}
}
declare module './item.mjs' {
export default interface DHItem<T extends BaseDataItem = BaseDataItem> {
parent: DhpActor;
actor: DhpActor;
system: T;
effects: EmbeddedCollection<DhActiveEffect>;
}
}

View file

@ -212,7 +212,7 @@ export default class DhActiveEffect extends foundry.documents.ActiveEffect {
try {
const evl = new Function('sandbox', `with (sandbox) { return ${expression}}`);
result = evl(Roll.MATH_PROXY);
} catch (err) {
} catch {
return expression;
}

View file

@ -531,21 +531,7 @@ export default class DhpActor extends Actor {
}
/**
* @param {object} config
* @param {Event} config.event
* @param {string} config.title
* @param {object} config.roll
* @param {number} config.roll.modifier
* @param {boolean} [config.roll.simple=false]
* @param {string} [config.roll.type]
* @param {number} [config.roll.difficulty]
* @param {boolean} [config.hasDamage]
* @param {boolean} [config.hasEffect]
* @param {object} [config.chatMessage]
* @param {string} config.chatMessage.template
* @param {boolean} [config.chatMessage.mute]
* @param {object} [config.targets]
* @param {object} [config.costs]
* @param {Partial<RollConfig>} config
*/
async diceRoll(config) {
config.source = { ...(config.source ?? {}), actor: this.uuid };