[PR][Fix] Cleaned Up Countdown Ownership View (#1459)

* Removed the disabled default ownership select in the ownership view. Added a fallback text incase there are no players added yet

* Corrected noPlayers condition

lang/en.json

@@ -586,6 +586,7 @@
             },
             "OwnershipSelection": {
                 "title": "Ownership Selection - {name}",
+                "noPlayers": "No players to assign ownership to",
                 "default": "Default Ownership"
             },
             "ReactionRoll": {

module/applications/dialogs/ownershipSelection.mjs

@@ -38,7 +38,6 @@ export default class OwnershipSelection extends HandlebarsApplicationMixin(Appli
 
     async _prepareContext(_options) {
         const context = await super._prepareContext(_options);
-        context.ownershipDefaultOptions = CONFIG.DH.GENERAL.basicOwnershiplevels;
         context.ownershipOptions = CONFIG.DH.GENERAL.simpleOwnershiplevels;
         context.defaultOwnership = this.defaultOwnership;
         context.ownership = game.users.reduce((acc, user) => {
@@ -52,6 +51,7 @@ export default class OwnershipSelection extends HandlebarsApplicationMixin(Appli
 
             return acc;
         }, {});
+        context.showOwnership = Boolean(Object.keys(context.ownership).length);
 
         return context;
     }

styles/less/ui/ownership-selection/ownership-selection.less

@@ -36,6 +36,10 @@
             }
         }
 
+        .hint {
+            text-align: center;
+        }
+
         footer {
             margin-top: 10px;
             button {

system.json

@@ -2,7 +2,7 @@
     "id": "daggerheart",
     "title": "Daggerheart",
     "description": "An unofficial implementation of the Daggerheart system",
-    "version": "1.3.2",
+    "version": "1.4.0",
     "compatibility": {
         "minimum": "13.346",
         "verified": "13.351",

templates/dialogs/ownershipSelection.hbs

@@ -1,23 +1,19 @@
 <div class="ownership-outer-container">
-    <div class="form-group">
-        <div class="form-fields">
-            <label>{{localize "DAGGERHEART.APPLICATIONS.OwnershipSelection.default"}}</label>
-            <select name="default" data-dtype="Number" disabled>
-                {{selectOptions ownershipDefaultOptions selected=defaultOwnership labelAttr="label" valueAttr="value" localize=true }}
-            </select>
-        </div>
-    </div>
-    <ul class="ownership-list">
-        {{#each ownership as |player id|}}
-            <li class="ownership-container">
-                <img src="{{player.img}}" />
-                <span>{{player.name}}</span>
-                <select name="{{concat "ownership." id}}" data-dtype="Number">
-                    {{selectOptions @root.ownershipOptions selected=player.ownership  labelAttr="label" valueAttr="value" localize=true }}
-                </select>
-            </li>
-        {{/each}}
-    </ul>
+    {{#if showOwnership}}
+        <ul class="ownership-list">
+            {{#each ownership as |player id|}}
+                <li class="ownership-container">
+                    <img src="{{player.img}}" />
+                    <span>{{player.name}}</span>
+                    <select name="{{concat "ownership." id}}" data-dtype="Number">
+                        {{selectOptions @root.ownershipOptions selected=player.ownership  labelAttr="label" valueAttr="value" localize=true }}
+                    </select>
+                </li>
+            {{/each}}
+        </ul>
+    {{else}}
+        <span class="hint">{{localize "DAGGERHEART.APPLICATIONS.OwnershipSelection.noPlayers"}}</span>
+    {{/if}}
     <footer class="flexrow">
         <button type="submit">{{localize "Save"}}</button>
     </footer>