[Fix] Compendium Advantage Sources (#1796)

* Duration Description field didn't show initially for type temporary

* Corrected SRD

src/packs/ancestries/feature_Retract_UFR67BUOhNGLFyg9.json

@@ -68,31 +68,33 @@
           "type": "withinRange",
           "target": "hostile",
           "range": "melee"
-        }
         },
         "changes": [
           {
             "key": "system.resistance.physical.resistance",
-          "mode": 5,
+            "type": "override",
-          "value": "1",
+            "value": 1,
-          "priority": null
+            "priority": null,
+            "phase": "initial"
           },
           {
             "key": "system.disadvantageSources",
-          "mode": 2,
+            "type": "add",
-          "value": "Retract",
+            "value": "Action rolls",
-          "priority": null
+            "priority": null,
+            "phase": "initial"
           }
         ],
+        "duration": {
+          "type": ""
+        }
+      },
       "disabled": true,
       "duration": {
-        "startTime": null,
+        "value": null,
-        "combat": null,
+        "units": "seconds",
-        "seconds": null,
+        "expiry": null,
-        "rounds": null,
+        "expired": false
-        "turns": null,
-        "startRound": null,
-        "startTurn": null
       },
       "description": "<p>While in your shell, you have resistance to physical damage, you have disadvantage on action rolls, and you can’t move.</p>",
       "tint": "#ffffff",
@@ -102,6 +104,16 @@
       "_stats": {
         "compendiumSource": null
       },
+      "start": {
+        "time": 0,
+        "combat": null,
+        "combatant": null,
+        "initiative": null,
+        "round": null,
+        "turn": null
+      },
+      "showIcon": 1,
+      "folder": null,
       "_key": "!items.effects!UFR67BUOhNGLFyg9.3V4FPoyjJUnFP9WS"
     }
   ],

src/packs/communities/feature_Low_Light_Living_aMla3xQuCHEwORGD.json

@@ -29,39 +29,28 @@
           "type": "withinRange",
           "target": "hostile",
           "range": "melee"
-        }
         },
         "changes": [
           {
             "key": "system.advantageSources",
-          "mode": 2,
+            "type": "add",
-          "value": "In an area with low light or heavy shadow: hide, investigate, or perceive",
+            "value": "Rolls to hide, investigate, or perceive details in low light",
-          "priority": null
+            "priority": null,
-        },
+            "phase": "initial"
-        {
-          "key": "system.advantageSources",
-          "mode": 2,
-          "value": "",
-          "priority": null
-        },
-        {
-          "key": "",
-          "mode": 2,
-          "value": "",
-          "priority": null
           }
         ],
+        "duration": {
+          "type": ""
+        }
+      },
       "disabled": false,
       "duration": {
-        "startTime": null,
+        "value": null,
-        "combat": null,
+        "units": "seconds",
-        "seconds": null,
+        "expiry": null,
-        "rounds": null,
+        "expired": false
-        "turns": null,
-        "startRound": null,
-        "startTurn": null
       },
-      "description": "",
+      "description": "<p>When you’re in an area with low light or heavy shadow, you have advantage on rolls to hide, investigate, or perceive details within that area.</p>",
       "origin": null,
       "tint": "#ffffff",
       "transfer": true,
@@ -71,6 +60,16 @@
       "_stats": {
         "compendiumSource": null
       },
+      "start": {
+        "time": 0,
+        "combat": null,
+        "combatant": null,
+        "initiative": null,
+        "round": null,
+        "turn": null
+      },
+      "showIcon": 1,
+      "folder": null,
       "_key": "!items.effects!aMla3xQuCHEwORGD.pCp32u7UwqxCI4WW"
     }
   ],

src/packs/domains/domainCard_Battle_Cry_Ef1JsUG50LIoKx2F.json

@@ -132,27 +132,29 @@
           "type": "withinRange",
           "target": "hostile",
           "range": "melee"
-        }
         },
         "changes": [
           {
             "key": "system.advantageSources",
-          "mode": 2,
+            "type": "add",
-          "value": "1",
+            "value": "On Attacks",
-          "priority": null
+            "priority": null,
+            "phase": "initial"
           }
         ],
+        "duration": {
+          "type": "temporary",
+          "description": "<p>Until you or an ally rolls a failure with Fear.</p>"
+        }
+      },
       "disabled": false,
       "duration": {
-        "startTime": null,
+        "value": null,
-        "combat": null,
+        "units": "seconds",
-        "seconds": null,
+        "expiry": null,
-        "rounds": null,
+        "expired": false
-        "turns": null,
-        "startRound": null,
-        "startTurn": null
       },
-      "description": "",
+      "description": "<p>You gain advantage on attack rolls until you or an ally rolls a failure with Fear.</p>",
       "tint": "#ffffff",
       "statuses": [],
       "sort": 0,
@@ -160,6 +162,16 @@
       "_stats": {
         "compendiumSource": null
       },
+      "start": {
+        "time": 0,
+        "combat": null,
+        "combatant": null,
+        "initiative": null,
+        "round": null,
+        "turn": null
+      },
+      "showIcon": 1,
+      "folder": null,
       "_key": "!items.effects!Ef1JsUG50LIoKx2F.s7ma4TNgAvt0ZgEW"
     }
   ],

templates/sheets/activeEffect/settings.hbs

@@ -26,7 +26,7 @@
 
         {{formGroup systemFields.duration.fields.type value=source.system.duration.type localize=true }}
 
-            <div class="form-group slim duration-description">
+        <div class="form-group slim duration-description {{#if (eq source.system.duration.type 'temporary')}}visible{{/if}}">
             <div class="form-fields">
                 {{formInput systemFields.duration.fields.description value=source.system.duration.description localize=true }}
             </div>