Refactor/275 actor sheets simplification (#291)

* FEAT: create isNPC geeter and add the prop on metada on actors
FEAT: create common method for documents sheets
FEAT: create BaseActorSheet and implementation

* FIX: tabs label

* REFACTOR: remove unused methods
REFACTOR: simplify CharacterSheet's click actions methods
REFACTOR: minor fix on DHActor class

* REFACTOR: remove unused methods
REFACTOR: create method on BaseActorSheet
REFACTOR: make Datamodel metadata getter

* REFACTOR: remove unused method on setting sheet
FEAT: create BaseActorSetting
FIX: add type="button" to button on actor's sheet

* FIX jsdoc

* PRETTIER

---------

Co-authored-by: Joaquin Pereyra <joaquinpereyra98@users.noreply.github.com>

templates/sheets-settings/adversary-settings/experiences.hbs

@@ -3,7 +3,7 @@
     data-tab='{{tabs.experiences.id}}'
     data-group='{{tabs.experiences.group}}'
 >
-    <button class="add-experience-btn" type="button" data-action="addExperience">
+    <button type="button" class="add-experience-btn" type="button" data-action="addExperience">
         <span>New Experience</span>
     </button>
 

templates/sheets-settings/adversary-settings/features.hbs

@@ -3,7 +3,7 @@
     data-tab='{{tabs.features.id}}'
     data-group='{{tabs.features.group}}'
 >
-    <button class="add-feature-btn" data-action="addFeature">
+    <button type="button" class="add-feature-btn" data-action="createDoc" data-document-class="Item" data-type="feature">
         {{localize "DOCUMENT.New" type=(localize "TYPES.Item.feature")}}
     </button>
     <fieldset>
@@ -16,8 +16,8 @@
                         <span>{{feature.name}}</span>
                     </div>
                     <div class="controls">
-                        <a data-action="editFeature" id="{{feature.id}}" data-tooltip="{{localize 'DAGGERHEART.Tooltip.edit'}}"><i class="fa-solid fa-pen-to-square"></i></a>
-                        <a data-action="removeFeature" id="{{feature.id}}" data-tooltip="{{localize 'CONTROLS.CommonDelete'}}"><i class="fa-solid fa-trash"></i></a>
+                        <a data-action="editDoc" data-type="Item" data-doc-id="{{feature.id}}" data-tooltip="{{localize 'DAGGERHEART.Tooltip.edit'}}"><i class="fa-solid fa-pen-to-square"></i></a>
+                        <a data-action="deleteDoc"  data-type="Item" data-doc-id="{{feature.id}}" data-tooltip="{{localize 'CONTROLS.CommonDelete'}}"><i class="fa-solid fa-trash"></i></a>
                     </div>
                 </li>
             {{/each}}

templates/sheets-settings/companion-settings/details.hbs

@@ -13,11 +13,11 @@
         <div class="form-group">
         <div class="form-fields">
             <label>{{localize "DAGGERHEART.ACTORS.Companion.FIELDS.partner.label"}}</label>
-            <select class="partner-value">
+            <select class="partner-value" name="system.partner">
                 {{selectOptions playerCharacters selected=document.system.partner.uuid labelAttr="name" valueAttr="key" blank=""}}
             </select>
         </div>
     </div>
     </fieldset>
-    <button data-action="levelUp" {{#if (not document.system.levelData.canLevelUp)}}disabled{{/if}}>Level Up</button>
+    <button type="button" data-action="levelUp" {{#if (not document.system.levelData.canLevelUp)}}disabled{{/if}}>Level Up</button>
 </section>

templates/sheets-settings/environment-settings/adversaries.hbs

@@ -3,18 +3,20 @@
     data-tab='{{tabs.adversaries.id}}'
     data-group='{{tabs.adversaries.group}}'
 >    
-    <button class="add-action-btn" data-action="addCategory">
+    <button type="button" class="add-action-btn" data-action="addCategory">
         New Category
     </button>
-    {{#each document.system.potentialAdversaries}}
-        <fieldset class="category-container" data-potential-adversary="{{@key}}">
-            <legend>{{this.label}}</legend>
+    {{#each document.system.potentialAdversaries as |category id|}}
+        <fieldset class="category-container" data-potential-adversary="{{id}}">
+            <legend>{{category.label}}</legend>
             <div class="category-name">
-                <input type="text" name="{{concat "system.potentialAdversaries." @key ".label" }}" value="{{this.label}}" />
-                <a><i class="fa-solid fa-trash" data-action="deleteProperty" data-path="system.potentialAdversaries" id={{@key}} data-tooltip='{{localize "CONTROLS.CommonDelete"}}'></i></a>
+                <input type="text" name="{{concat "system.potentialAdversaries." @key ".label" }}" value="{{category.label}}" />
+                <a data-action="removeCategory" data-category-id={{id}} data-tooltip='{{localize "CONTROLS.CommonDelete"}}'>
+                    <i class="fa-solid fa-trash"></i>
+                </a>
             </div>
             <div class="adversaries-container">
-                {{#each this.adversaries as |adversary|}}
+                {{#each category.adversaries as |adversary|}}
                     <div class="adversary-container">
                         {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-item.hbs' item=adversary type='adversary' isActor=true categoryAdversary=@../key}}
                     </div>

templates/sheets-settings/environment-settings/features.hbs

@@ -3,7 +3,7 @@
     data-tab='{{tabs.features.id}}'
     data-group='{{tabs.features.group}}'
 >
-    <button class="add-feature-btn" data-action="addFeature">
+    <button type="button" class="add-feature-btn" data-action="createDoc" data-document-class="Item" data-type="feature">
         {{localize "DOCUMENT.New" type=(localize "TYPES.Item.feature")}}
     </button>
     <fieldset>
@@ -16,8 +16,8 @@
                         <span>{{feature.name}}</span>
                     </div>
                     <div class="controls">
-                        <a data-action="editFeature" id="{{feature.id}}" data-tooltip="{{localize 'DAGGERHEART.Tooltip.edit'}}"><i class="fa-solid fa-pen-to-square"></i></a>
-                        <a data-action="removeFeature" id="{{feature.id}}" data-tooltip="{{localize 'CONTROLS.CommonDelete'}}"><i class="fa-solid fa-trash"></i></a>
+                        <a data-action="editDoc" data-type="Item" data-doc-id="{{feature.id}}" data-tooltip="{{localize 'DAGGERHEART.Tooltip.edit'}}"><i class="fa-solid fa-pen-to-square"></i></a>
+                        <a data-action="deleteDoc"  data-type="Item" data-doc-id="{{feature.id}}" data-tooltip="{{localize 'CONTROLS.CommonDelete'}}"><i class="fa-solid fa-trash"></i></a>
                     </div>
                 </li>
             {{/each}}

templates/sheets/actors/character/header.hbs

@@ -13,7 +13,8 @@
         <div class='level-div'>
             <h3 class='label'>
                 {{#if (or document.system.needsCharacterSetup document.system.levelData.canLevelUp)}}
-                    <button 
+                    <button
+                        type="button"
                         class="level-button glow" data-tooltip="{{#if document.system.needsCharacterSetup}}{{localize "DAGGERHEART.Sheets.PC.CharacterSetup"}}{{else}}{{localize "DAGGERHEART.ACTORS.Character.levelUp"}}{{/if}}"
                         data-action="levelManagement"
                     >
@@ -28,42 +29,42 @@
     <div class="character-details">
         <div>
             {{#if document.system.class.value}}
-                <span data-action="viewObject" data-value="{{document.system.class.value.uuid}}">{{document.system.class.value.name}}</span>
+                <span data-action="editDoc" data-type="Item" data-doc-id="{{document.system.class.value.id}}">{{document.system.class.value.name}}</span>
             {{else}}
-                <span>{{localize 'TYPES.Item.class'}}</span>
+                <span data-action="openPack" data-key="daggerheart.classes">{{localize 'TYPES.Item.class'}}</span>
             {{/if}}
             <span class="dot">•</span>
             {{#if document.system.class.subclass}}
-                <span data-action="viewObject" data-value="{{document.system.class.subclass.uuid}}">{{document.system.class.subclass.name}}</span>
+                <span data-action="editDoc" data-type="Item" data-doc-id="{{document.system.class.subclass.id}}">{{document.system.class.subclass.name}}</span>
             {{else}}
-                <span data-action="selectSubclass">{{localize 'TYPES.Item.subclass'}}</span>
+                <span data-action="openPack" data-key="daggerheart.subclass">{{localize 'TYPES.Item.subclass'}}</span>
             {{/if}}
             <span class="dot">•</span>
             {{#if document.system.community}}
-                <span data-action="viewObject" data-value="{{document.system.community.uuid}}">{{document.system.community.name}}</span>
+                <span data-action="editDoc" data-type="Item" data-doc-id="{{document.system.community.id}}">{{document.system.community.name}}</span>
             {{else}}
-                <span data-action="selectCommunity">{{localize 'TYPES.Item.community'}}</span>
+                <span data-action="openPack" data-key="daggerheart.community">{{localize 'TYPES.Item.community'}}</span>
             {{/if}}
             <span class="dot">•</span>
             {{#if document.system.ancestry}}
-                <span data-action="viewObject" data-value="{{document.system.ancestry.uuid}}">{{document.system.ancestry.name}}</span>
+                <span data-action="editDoc" data-type="Item" data-doc-id="{{document.system.ancestry.id}}">{{document.system.ancestry.name}}</span>
             {{else}}
-                <span data-action="selectAncestry">{{localize 'TYPES.Item.ancestry'}}</span>
+                <span data-action="openPack" data-key="daggerheart.ancestry">{{localize 'TYPES.Item.ancestry'}}</span>
             {{/if}}
         </div>
 
         {{#if document.system.multiclass.value}}
             <div class="multiclass">
                 {{#if document.system.multiclass.value}}
-                    <span data-action="viewObject" data-value="{{document.system.multiclass.value.uuid}}">{{document.system.multiclass.value.name}}</span>
+                    <span data-action="editDoc" data-type="Item" data-doc-id="{{document.system.multiclass.value.id}}">{{document.system.multiclass.value.name}}</span>
                 {{else}}
-                    <span>{{localize 'DAGGERHEART.GENERAL.multiclass'}}</span>
+                    <span data-action="openPack" data-key="daggerheart.classes">{{localize 'DAGGERHEART.GENERAL.multiclass'}}</span>
                 {{/if}}
                 <span class="dot">•</span>
                 {{#if document.system.multiclass.subclass}}
-                    <span data-action="viewObject" data-value="{{document.system.multiclass.subclass.uuid}}">{{document.system.multiclass.subclass.name}}</span>
+                    <span data-action="editDoc" data-type="Item" data-doc-id="{{document.system.multiclass.subclass.id}}">{{document.system.multiclass.subclass.name}}</span>
                 {{else}}
-                    <span data-action="selectSubclass">{{localize 'TYPES.Item.subclass'}}</span>
+                    <span data-action="openPack" data-key="daggerheart.subclass">{{localize 'TYPES.Item.subclass'}}</span>
                 {{/if}}
             </div>
         {{/if}}
@@ -95,7 +96,7 @@
 
     <div class="character-traits">
         {{#each this.attributes as |attribute key|}}
-            <div class="trait" data-tooltip="{{#each attribute.verbs}}{{this}}<br>{{/each}}" data-action="attributeRoll" data-attribute="{{key}}" data-value="{{attribute.total}}">
+            <div class="trait" data-tooltip="{{#each attribute.verbs}}{{this}}<br>{{/each}}" data-action="rollAttribute" data-attribute="{{key}}" data-value="{{attribute.total}}">
                 <div class="trait-name">
                     <span>{{localize (concat 'DAGGERHEART.CONFIG.Traits.' key '.short')}}</span>
                     {{#if attribute.tierMarked}}

templates/sheets/actors/character/loadout.hbs

@@ -1,8 +1,5 @@
-<section
-    class='tab {{tabs.loadout.cssClass}} {{tabs.loadout.id}}'
-    data-tab='{{tabs.loadout.id}}'
-    data-group='{{tabs.loadout.group}}'
->
+<section class='tab {{tabs.loadout.cssClass}} {{tabs.loadout.id}}' data-tab='{{tabs.loadout.id}}'
+    data-group='{{tabs.loadout.group}}'>
     <div class="search-section">
         <div class="search-bar">
             <div class="icon">
@@ -13,29 +10,28 @@
         <a class="filter-button">
             <i class="fa-solid fa-filter"></i>
         </a>
-        <button class="btn-toggle-view" data-action="toggleLoadoutView" data-value="{{this.abilities.loadout.listView}}">
-            <span class="{{#if this.abilities.loadout.listView}}list-active{{/if}} list-icon">
+        <button type="button" class="btn-toggle-view" data-action="toggleLoadoutView" data-value="{{listView}}">
+            <span class="{{ifThen listView 'list-active' ''}} list-icon">
                 <i class="fa-solid fa-bars"></i>
             </span>
-            <span class="{{#unless this.abilities.loadout.listView}}grid-active{{/unless}} grid-icon">
+            <span class="{{ifThen listView '' 'grid-active'}} grid-icon">
                 <i class="fa-solid fa-grip"></i>
             </span>
         </button>
     </div>
 
     <div class="items-section">
-        {{#if this.abilities.loadout.listView}}
-        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-fieldset-items.hbs' title=(localize 'DAGGERHEART.GENERAL.Tabs.loadout') type='domainCard' isGlassy=true cardView='list'}}
-        {{else}}
-        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-fieldset-items.hbs' title=(localize 'DAGGERHEART.GENERAL.Tabs.loadout') type='domainCard' isGlassy=true cardView='card'}}
-        {{/if}}
+        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-fieldset-items.hbs'
+        title=(localize 'DAGGERHEART.GENERAL.Tabs.loadout')
+        type='domainCard'
+        isGlassy=true
+        cardView=(ifThen listView "list" "card")}}
 
-        {{#if this.abilities.loadout.listView}}
-        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-fieldset-items.hbs' title=(localize 'DAGGERHEART.GENERAL.Tabs.vault') type='domainCard' isVault=true isGlassy=true cardView='list'}}
-        {{else}}
-        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-fieldset-items.hbs' title=(localize 'DAGGERHEART.GENERAL.Tabs.vault') type='domainCard' isVault=true isGlassy=true cardView='card'}}
-        {{/if}}
-        
-        
+        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-fieldset-items.hbs'
+        title=(localize 'DAGGERHEART.GENERAL.Tabs.vault')
+        type='domainCard'
+        isVault=true
+        isGlassy=true
+        cardView=(ifThen listView "list" "card")}}
     </div>
 </section>

templates/sheets/actors/character/sidebar.hbs

@@ -1,7 +1,7 @@
 <aside class="character-sidebar-sheet">
-    <div class="portrait {{#if document.system.deathMoveViable}}death-roll{{/if}}">
+    <div class="portrait {{#if isDeath}}death-roll{{/if}}">
         <img src="{{document.img}}" alt="{{document.name}}" data-action='editImage' data-edit="img">
-        <a class="death-roll-btn" data-tooltip="{{localize "DAGGERHEART.UI.Tooltip.makeDeathMove"}}" data-action="makeDeathMove"><i class="fas fa-skull death-save" ></i></a>
+        <a class="death-roll-btn" data-tooltip="{{localize "DAGGERHEART.UI.Tooltip.makeDeathMove"}}" {{#if isDeath}}data-action="makeDeathMove"{{/if}}><i class="fas fa-skull death-save" ></i></a>
     </div>
     
     <div class="info-section">

templates/sheets/actors/companion/header.hbs

@@ -39,7 +39,7 @@
     </div>
     <div class="companion-navigation">
         {{> 'systems/daggerheart/templates/sheets/global/tabs/tab-navigation.hbs'}}
-        <button data-action="openSettings">
+        <button type="button" data-action="openSettings">
             <i class="fa-solid fa-wrench"></i>
         </button>
     </div>

templates/sheets/actors/environment/header.hbs

@@ -42,7 +42,7 @@
     </div>
     <div class="environment-navigation">
         {{> 'systems/daggerheart/templates/sheets/global/tabs/tab-navigation.hbs'}}
-        <button data-action="openSettings">
+        <button type="button" data-action="openSettings">
             <i class="fa-solid fa-wrench"></i>
         </button>
     </div>

templates/sheets/global/partials/domain-card-item.hbs

@@ -3,12 +3,12 @@
     <div class="card-label">
         <div class="controls">
             {{#if (eq type 'weapon')}}
-                <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" id="{{item.id}}" data-tooltip="{{#unless item.system.equipped}}{{localize 'CONTROLS.CommonEdit'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
+                <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'DAGGERHEART.UI.Tooltip.equip'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
                     <i class="fa-solid fa-hands"></i>
                 </a>
             {{/if}}
             {{#if (eq type 'armor')}}
-                <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" id="{{item.id}}" data-tooltip="{{#unless item.system.equipped}}{{localize 'CONTROLS.CommonEdit'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
+                <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'DAGGERHEART.UI.Tooltip.equip'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
                 <i class="fa-solid fa-shield"></i>
                 </a>
             {{/if}}

templates/sheets/global/partials/inventory-item.hbs

@@ -142,12 +142,12 @@
         {{else}}
             <div class="controls">
                 {{#if (eq type 'weapon')}}
-                    <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'CONTROLS.CommonEdit'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
+                    <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'DAGGERHEART.UI.Tooltip.equip'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
                         <i class="fa-solid fa-hands"></i>
                     </a>
                 {{/if}}
                 {{#if (eq type 'armor')}}
-                    <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'CONTROLS.CommonEdit'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
+                    <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'DAGGERHEART.UI.Tooltip.equip'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
                     <i class="fa-solid fa-shield"></i>
                     </a>
                 {{/if}}

templates/sheets/global/tabs/tab-effects.hbs

@@ -4,15 +4,20 @@
     data-group='{{tabs.effects.group}}'
 >
     <fieldset class="one-column">
-            <legend>{{localize "DAGGERHEART.GENERAL.Effect.plural"}} <a><i class="fa-solid fa-plus icon-button" data-action="addEffect"></i></a></legend>
+            <legend>
+                {{localize "DAGGERHEART.GENERAL.Effect.plural"}} 
+                <a data-action="createDoc" data-document-class="ActiveEffect" data-type="base">
+                    <i class="fa-solid fa-plus icon-button"></i>
+                </a>
+            </legend>
         <div class="effects-list">
             {{#each document.effects as |effect|}}
                 <div class="effect-item">
                     <img class="image" src="{{effect.img}}" />
                     <span>{{effect.name}}</span>
                     <div class="controls">
-                        <a data-action="editEffect" data-effect="{{effect.id}}"><i class="fa-solid fa-pen-to-square"></i></a>
-                        <a data-action="removeEffect" data-effect="{{effect.id}}"><i class="fa-solid fa-trash"></i></a>
+                        <a data-action="editDoc" data-type="ActiveEffect" data-doc-id="{{effect.id}}"><i class="fa-solid fa-pen-to-square"></i></a>
+                        <a data-action="deleteDoc" data-type="ActiveEffect" data-doc-id="{{effect.id}}"><i class="fa-solid fa-trash"></i></a>
                     </div>
                 </div> 
             {{/each}}