Refactor/275 actor sheets simplification (#291)

* FEAT: create isNPC geeter and add the prop on metada on actors
FEAT: create common method for documents sheets
FEAT: create BaseActorSheet and implementation

* FIX: tabs label

* REFACTOR: remove unused methods
REFACTOR: simplify CharacterSheet's click actions methods
REFACTOR: minor fix on DHActor class

* REFACTOR: remove unused methods
REFACTOR: create method on BaseActorSheet
REFACTOR: make Datamodel metadata getter

* REFACTOR: remove unused method on setting sheet
FEAT: create BaseActorSetting
FIX: add type="button" to button on actor's sheet

* FIX jsdoc

* PRETTIER

---------

Co-authored-by: Joaquin Pereyra <joaquinpereyra98@users.noreply.github.com>

module/data/actor/adversary.mjs

@@ -1,3 +1,4 @@
+import DHAdversarySettings from '../../applications/sheets-configs/adversary-settings.mjs';
 import ActionField from '../fields/actionField.mjs';
 import BaseDataActor from './base.mjs';
 
@@ -13,7 +14,8 @@ export default class DhpAdversary extends BaseDataActor {
     static get metadata() {
         return foundry.utils.mergeObject(super.metadata, {
             label: 'TYPES.Actor.adversary',
-            type: 'adversary'
+            type: 'adversary',
+            settingSheet: DHAdversarySettings,
         });
     }
 

module/data/actor/base.mjs

@@ -1,18 +1,29 @@
+import DHBaseActorSettings from "../../applications/sheets/api/actor-setting.mjs";
+
 /**
  * Describes metadata about the actor data model type
  * @typedef {Object} ActorDataModelMetadata
  * @property {string} label - A localizable label used on application.
  * @property {string} type - The system type that this data model represents.
+ * @property {Boolean} isNPC - This data model represents a NPC?
+ * @property {typeof DHBaseActorSettings} settingSheet - The sheet class used to render the settings UI for this actor type.
  */
 export default class BaseDataActor extends foundry.abstract.TypeDataModel {
     /** @returns {ActorDataModelMetadata}*/
     static get metadata() {
         return {
             label: 'Base Actor',
-            type: 'base'
+            type: 'base',
+            isNPC: true,
+            settingSheet: null,
         };
     }
 
+    /**@returns {ActorDataModelMetadata}*/
+    get metadata() {
+        return this.constructor.metadata;
+    }
+
     /** @inheritDoc */
     static defineSchema() {
         const fields = foundry.data.fields;

module/data/actor/character.mjs

@@ -28,7 +28,8 @@ export default class DhCharacter extends BaseDataActor {
     static get metadata() {
         return foundry.utils.mergeObject(super.metadata, {
             label: 'TYPES.Actor.character',
-            type: 'character'
+            type: 'character',
+            isNPC: false,
         });
     }
 

module/data/actor/companion.mjs

@@ -3,6 +3,7 @@ import DhLevelData from '../levelData.mjs';
 import ForeignDocumentUUIDField from '../fields/foreignDocumentUUIDField.mjs';
 import ActionField from '../fields/actionField.mjs';
 import { adjustDice, adjustRange } from '../../helpers/utils.mjs';
+import DHCompanionSettings from '../../applications/sheets-configs/companion-settings.mjs';
 
 export default class DhCompanion extends BaseDataActor {
     static LOCALIZATION_PREFIXES = ['DAGGERHEART.ACTORS.Companion'];
@@ -10,7 +11,8 @@ export default class DhCompanion extends BaseDataActor {
     static get metadata() {
         return foundry.utils.mergeObject(super.metadata, {
             label: 'TYPES.Actor.companion',
-            type: 'companion'
+            type: 'companion',
+            settingSheet: DHCompanionSettings
         });
     }
 

module/data/actor/environment.mjs

@@ -1,5 +1,6 @@
 import BaseDataActor from './base.mjs';
 import ForeignDocumentUUIDArrayField from '../fields/foreignDocumentUUIDArrayField.mjs';
+import DHEnvironmentSettings from '../../applications/sheets-configs/environment-settings.mjs';
 
 export default class DhEnvironment extends BaseDataActor {
     static LOCALIZATION_PREFIXES = ['DAGGERHEART.ACTORS.Environment'];
@@ -7,7 +8,8 @@ export default class DhEnvironment extends BaseDataActor {
     static get metadata() {
         return foundry.utils.mergeObject(super.metadata, {
             label: 'TYPES.Actor.environment',
-            type: 'environment'
+            type: 'environment',
+            settingSheet: DHEnvironmentSettings
         });
     }