From 7b820d4c6097afb8b8e45f7c1d16b778e93753a2 Mon Sep 17 00:00:00 2001 From: George Brocklehurst Date: Sat, 19 Jul 2025 16:36:45 +0100 Subject: [PATCH] Refactor: handle button data attrs the same. A small refactor to handle `button.dataset.move` (which was assigned to a local const) and `button.dataset.category` (which was accessed directly) in the same way by assigning them both to local consts. --- module/applications/dialogs/downtime.mjs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/module/applications/dialogs/downtime.mjs b/module/applications/dialogs/downtime.mjs index 15add3ad..a011f0e7 100644 --- a/module/applications/dialogs/downtime.mjs +++ b/module/applications/dialogs/downtime.mjs @@ -113,10 +113,9 @@ export default class DhpDowntime extends HandlebarsApplicationMixin(ApplicationV deselectMove(event) { const button = event.target.closest('.activity-container'); - const move = button.dataset.move; - this.moveData[button.dataset.category].moves[move].selected = this.moveData[button.dataset.category].moves[move] - .selected - ? this.moveData[button.dataset.category].moves[move].selected - 1 + const { move, category } = button.dataset; + this.moveData[category].moves[move].selected = this.moveData[category].moves[move].selected + ? this.moveData[category].moves[move].selected - 1 : 0; this.render();