Add eslint and run linter in workflow

.editorconfig

@@ -1,3 +1,5 @@
 [*]
 indent_size = 4
 indent_style = spaces
+[*.yml]
+indent_size = 2

.github/workflows/ci.yml

@@ -0,0 +1,42 @@
+name: Project CI
+
+on:
+  pull_request:
+    branches: [main]
+  push:
+    branches: [main]
+  workflow_dispatch:
+    branches: [main]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [24.x]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - uses: pnpm/action-setup@v4
+        with:
+          version: 10
+
+      - name: Cache NPM Deps
+        id: cache-npm
+        uses: actions/cache@v3
+        with:
+          path: node_modules/
+          key: npm-${{ hashFiles('package-lock.json') }}
+
+      - name: Install NPM Deps
+        if: ${{ steps.cache-npm.outputs.cache-hit != 'true' }}
+        run: npm ci
+
+      - name: Lint
+        run: npm run lint

daggerheart.mjs

@@ -356,7 +356,7 @@ Hooks.on(CONFIG.DH.HOOKS.hooksConfig.groupRollStart, async data => {
 
 const updateActorsRangeDependentEffects = async token => {
     if (!token) return;
-    
+
     const rangeMeasurement = game.settings.get(
         CONFIG.DH.id,
         CONFIG.DH.SETTINGS.gameSettings.variantRules

eslint.config.mjs

@@ -0,0 +1,14 @@
+import globals from 'globals';
+import { defineConfig } from 'eslint/config';
+import prettier from 'eslint-plugin-prettier';
+
+export default defineConfig([
+    { files: ['**/*.{js,mjs,cjs}'], languageOptions: { globals: globals.browser } },
+    { plugins: { prettier } },
+    {
+        files: ['**/*.{js,mjs,cjs}'],
+        rules: {
+            'prettier/prettier': 'error'
+        }
+    }
+]);

module/applications/sheets/actors/character.mjs

@@ -173,7 +173,7 @@ export default class CharacterSheet extends DHBaseActorSheet {
         // Overriden to only disable text inputs by default.
         // Everything else is done by checking @root.editable in the sheet
         const form = this.form;
-        for (const input of form.querySelectorAll("input:not([type=search]), .editor.prosemirror")) {
+        for (const input of form.querySelectorAll('input:not([type=search]), .editor.prosemirror')) {
             input.disabled = disabled;
         }
     }

module/applications/sheets/api/application-mixin.mjs

@@ -488,11 +488,10 @@ export default function DHApplicationMixin(Base) {
                     icon: 'fa-solid fa-explosion',
                     visible: target => {
                         const doc = getDocFromElementSync(target);
-                        return (
-                            doc?.isOwner &&
+                        const hasDamage =
                             !foundry.utils.isEmpty(doc?.system?.attack?.damage.parts) ||
-                            !foundry.utils.isEmpty(doc?.damage?.parts)
-                        );
+                            !foundry.utils.isEmpty(doc?.damage?.parts);
+                        return doc?.isOwner && hasDamage;
                     },
                     callback: async (target, event) => {
                         const doc = await getDocFromElement(target),

module/applications/sheets/items/feature.mjs

@@ -31,7 +31,7 @@ export default class FeatureSheet extends DHBaseItemSheet {
             labelPrefix: 'DAGGERHEART.GENERAL.Tabs'
         }
     };
-//Might be wrong location but testing out if here is okay.
+    //Might be wrong location but testing out if here is okay.
     /**@override */
     async _prepareContext(options) {
         const context = await super._prepareContext(options);

module/config/itemBrowserConfig.mjs

@@ -75,12 +75,17 @@ export const typeConfig = {
             {
                 key: 'type',
                 label: 'DAGGERHEART.GENERAL.type',
-                format: type => type ? `TYPES.Item.${type}` : '-'
+                format: type => (type ? `TYPES.Item.${type}` : '-')
             },
             {
                 key: 'system.secondary',
                 label: 'DAGGERHEART.UI.ItemBrowser.subtype',
-                format: isSecondary => (isSecondary ? 'DAGGERHEART.ITEMS.Weapon.secondaryWeapon.short' : isSecondary === false ? 'DAGGERHEART.ITEMS.Weapon.primaryWeapon.short' : '-')
+                format: isSecondary =>
+                    isSecondary
+                        ? 'DAGGERHEART.ITEMS.Weapon.secondaryWeapon.short'
+                        : isSecondary === false
+                          ? 'DAGGERHEART.ITEMS.Weapon.primaryWeapon.short'
+                          : '-'
             },
             {
                 key: 'system.tier',
@@ -260,12 +265,12 @@ export const typeConfig = {
             {
                 key: 'system.type',
                 label: 'DAGGERHEART.GENERAL.type',
-                format: type => type ? `DAGGERHEART.CONFIG.DomainCardTypes.${type}` : '-'
+                format: type => (type ? `DAGGERHEART.CONFIG.DomainCardTypes.${type}` : '-')
             },
             {
                 key: 'system.domain',
                 label: 'DAGGERHEART.GENERAL.Domain.single',
-                format: domain => domain ? CONFIG.DH.DOMAIN.allDomains()[domain].label : '-'
+                format: domain => (domain ? CONFIG.DH.DOMAIN.allDomains()[domain].label : '-')
             },
             {
                 key: 'system.level',

module/config/settingsConfig.mjs

@@ -42,7 +42,7 @@ export const gameSettings = {
     SpotlightRequestQueue: 'SpotlightRequestQueue',
     CompendiumBrowserSettings: 'CompendiumBrowserSettings',
     SpotlightTracker: 'SpotlightTracker',
-    ActiveParty: 'ActiveParty',
+    ActiveParty: 'ActiveParty'
 };
 
 export const actionAutomationChoices = {

module/data/action/baseAction.mjs

@@ -112,7 +112,7 @@ export default class DHBaseAction extends ActionMixin(foundry.abstract.DataModel
 
     /** Returns true if the current user is the owner of the containing item */
     get isOwner() {
-        return this.item?.isOwner ?? true; 
+        return this.item?.isOwner ?? true;
     }
 
     /**

module/data/actor/character.mjs

@@ -20,7 +20,7 @@ export default class DhCharacter extends DhCreature {
             settingSheet: DHCharacterSettings,
             isNPC: false,
             hasInventory: true,
-            quantifiable: ["loot", "consumable"]
+            quantifiable: ['loot', 'consumable']
         });
     }
 
@@ -302,7 +302,7 @@ export default class DhCharacter extends DhCreature {
                         choices: CONFIG.DH.GENERAL.dieFaces,
                         initial: null,
                         label: 'DAGGERHEART.ACTORS.Character.defaultDisadvantageDice'
-                    }),
+                    })
                 })
             })
         };
@@ -449,7 +449,7 @@ export default class DhCharacter extends DhCreature {
 
     /* All items are valid on characters */
     isItemValid() {
-        return true; 
+        return true;
     }
 
     /** @inheritDoc */

module/data/actor/companion.mjs

@@ -78,7 +78,7 @@ export default class DhCompanion extends DhCreature {
                         choices: CONFIG.DH.GENERAL.dieFaces,
                         initial: null,
                         label: 'DAGGERHEART.ACTORS.Character.defaultDisadvantageDice'
-                    }),
+                    })
                 })
             }),
             attack: new ActionField({

module/data/actor/party.mjs

@@ -9,7 +9,7 @@ export default class DhParty extends BaseDataActor {
     static get metadata() {
         return foundry.utils.mergeObject(super.metadata, {
             hasInventory: true,
-            quantifiable: ["weapon", "armor", "loot", "consumable"]
+            quantifiable: ['weapon', 'armor', 'loot', 'consumable']
         });
     }
 

module/data/fields/action/summonField.mjs

@@ -40,9 +40,7 @@ export default class DHSummonField extends fields.ArrayField {
             const roll = new Roll(itemAbleRollParse(summon.count, this.actor, this.item));
             await roll.evaluate();
             const count = roll.total;
-            if (!roll.isDeterministic && game.modules.get('dice-so-nice')?.active) 
-                rolls.push(roll);
-            
+            if (!roll.isDeterministic && game.modules.get('dice-so-nice')?.active) rolls.push(roll);
 
             const actor = await DHSummonField.getWorldActor(await foundry.utils.fromUuid(summon.actorUUID));
             /* Extending summon data in memory so it's available in actionField.toChat. Think it's harmless, but ugly. Could maybe find a better way. */

module/dice/dualityRoll.mjs

@@ -11,7 +11,9 @@ export default class DualityRoll extends D20Roll {
         this.rallyChoices = this.setRallyChoices();
         this.guaranteedCritical = options.guaranteedCritical;
 
-        const advantageFaces = data.rules?.roll?.defaultAdvantageDice ? Number.parseInt(data.rules.roll.defaultAdvantageDice) : 6
+        const advantageFaces = data.rules?.roll?.defaultAdvantageDice
+            ? Number.parseInt(data.rules.roll.defaultAdvantageDice)
+            : 6;
         this.advantageFaces = Number.isNaN(advantageFaces) ? 6 : advantageFaces;
     }
 

module/documents/activeEffect.mjs

@@ -200,7 +200,6 @@ export default class DhActiveEffect extends foundry.documents.ActiveEffect {
     static effectSafeEval(expression) {
         let result;
         try {
-            // eslint-disable-next-line no-new-func
             const evl = new Function('sandbox', `with (sandbox) { return ${expression}}`);
             result = evl(Roll.MATH_PROXY);
         } catch (err) {

module/documents/actor.mjs

@@ -602,7 +602,7 @@ export default class DhpActor extends Actor {
         rollData.system = this.system.getRollData();
         rollData.prof = this.system.proficiency ?? 1;
         rollData.cast = this.system.spellcastModifier ?? 1;
-    
+
         return rollData;
     }
 

module/documents/collections/actorCollection.mjs

@@ -3,7 +3,7 @@ export default class DhActorCollection extends foundry.documents.collections.Act
     get party() {
         const id = game.settings.get(CONFIG.DH.id, CONFIG.DH.SETTINGS.gameSettings.ActiveParty);
         const actor = game.actors.get(id);
-        return actor?.type === "party" ? actor : null;
+        return actor?.type === 'party' ? actor : null;
     }
 
     /** Ensure companions are initialized after all other subtypes. */

module/systemRegistration/settings.mjs

@@ -56,10 +56,10 @@ export const registerKeyBindings = () => {
     game.keybindings.register(CONFIG.DH.id, CONFIG.DH.SETTINGS.keybindings.partySheet, {
         name: _loc('DAGGERHEART.SETTINGS.Keybindings.partySheet.name'),
         hint: _loc('DAGGERHEART.SETTINGS.Keybindings.partySheet.hint'),
-        editable: [{ key: "KeyP" }],
+        editable: [{ key: 'KeyP' }],
         onDown: () => {
             const controlled = canvas.ready ? canvas.tokens.controlled : [];
-            const selectedParty = controlled.find((c) => c.actor?.type === 'party')?.actor;
+            const selectedParty = controlled.find(c => c.actor?.type === 'party')?.actor;
             const party = selectedParty ?? game.actors.party;
             if (!party) return;
 
@@ -215,6 +215,6 @@ const registerNonConfigSettings = () => {
         scope: 'world',
         config: false,
         type: String,
-        default: null,
+        default: null
     });
 };

package.json

@@ -17,13 +17,18 @@
     "pullYMLtoLDB": "node ./tools/pullYMLtoLDB.mjs",
     "pullYMLtoLDBBuild": "node ./tools/pullYMLtoLDB.mjs --build",
     "createSymlink": "node ./tools/create-symlink.mjs",
-    "setup:dev": "node ./tools/dev-setup.mjs"
+    "setup:dev": "node ./tools/dev-setup.mjs",
+    "lint": "eslint",
+    "lint:fix": "eslint --fix"
   },
   "devDependencies": {
     "@foundryvtt/foundryvtt-cli": "^1.0.2",
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-node-resolve": "^15.2.3",
     "concurrently": "^8.2.2",
+    "eslint": "^10.2.1",
+    "eslint-plugin-prettier": "^5.5.5",
+    "globals": "^17.5.0",
     "husky": "^9.1.5",
     "lint-staged": "^15.2.10",
     "postcss": "^8.4.32",

tools/pullYMLtoLDB.mjs

@@ -1,12 +1,12 @@
 import { compilePack } from '@foundryvtt/foundryvtt-cli';
 import readline from 'node:readline/promises';
 import { promises as fs } from 'fs';
-import systemJSON from "../system.json" with { type: "json" };
+import systemJSON from '../system.json' with { type: 'json' };
 
 const MODULE_ID = process.cwd();
 
 const answer = await (async () => {
-    if (process.argv.includes("--build")) return "overwrite";
+    if (process.argv.includes('--build')) return 'overwrite';
 
     const rl = readline.createInterface({
         input: process.stdin,
@@ -42,8 +42,8 @@ async function pullToLDB() {
     function transformEntry(entry) {
         const stats = {
             coreVersion: systemJSON.compatibility.minimum,
-            systemId: "daggerheart",
-            systemVersion: systemJSON.version,
+            systemId: 'daggerheart',
+            systemVersion: systemJSON.version
         };
 
         entry._stats = { ...stats };

tools/pushLDBtoYML.mjs

@@ -23,7 +23,7 @@ for (const pack of packs) {
     await extractPack(`${MODULE_ID}/${pack}`, `${MODULE_ID}/src/${pack}`, {
         yaml,
         transformName,
-        transformEntry,
+        transformEntry
     });
 }
 /**
@@ -45,12 +45,12 @@ function transformEntry(entry) {
 
     delete entry._stats;
     for (const effect of entry.effects ?? []) {
-        effect._stats = prune(effect._stats)
+        effect._stats = prune(effect._stats);
     }
     for (const item of entry.items ?? []) {
         item._stats = prune(item._stats);
         for (const effect of item.effects ?? []) {
-            effect._stats = prune(effect._stats)
+            effect._stats = prune(effect._stats);
         }
     }
 }