FEAT: add DHHeritageSheet

module/applications/sheets/api/_modules.mjs

@@ -1,2 +1,3 @@
-export {default as DHApplicationMixin} from "./application-mixin.mjs";
+export { default as DHApplicationMixin } from './application-mixin.mjs';
-export {default as DHBaseItemSheet} from "./base-item.mjs";
+export { default as DHBaseItemSheet } from './base-item.mjs';
+export { default as DHHeritageSheet } from './heritage-sheet.mjs';

module/applications/sheets/api/application-mixin.mjs

@@ -40,7 +40,11 @@ export default function DHApplicationMixin(Base) {
                 width: 480,
                 height: 'auto'
             },
-
+            actions: {
+                addEffect: DHSheetV2.#addEffect,
+                editEffect: DHSheetV2.#editEffect,
+                removeEffect: DHSheetV2.#removeEffect
+            },
             dragDrop: []
         };
 
@@ -75,7 +79,7 @@ export default function DHApplicationMixin(Base) {
          * @param {DragEvent} event
          * @protected
          */
-    _onDrop(event) { }
+        _onDrop(event) {}
 
         /* -------------------------------------------- */
         /*  Prepare Context                             */
@@ -96,6 +100,44 @@ export default function DHApplicationMixin(Base) {
             context.systemFields = this[objectPath].system ? this[objectPath].system.schema.fields : {};
             return context;
         }
+
+        /* -------------------------------------------- */
+        /*  Application Clicks Actions                  */
+        /* -------------------------------------------- */
+
+        /**
+         * Renders an ActiveEffect's sheet sheet.
+         * @param {PointerEvent} event - The originating click event
+         * @param {HTMLElement} button - The capturing HTML element which defines the [data-action="removeAction"]
+         */
+        static async #addEffect() {
+            const cls = foundry.documents.ActiveEffect;
+            await cls.create(
+                {
+                    name: game.i18n.format('DOCUMENT.New', { type: game.i18n.localize(cls.metadata.label) })
+                },
+                { parent: this.document }
+            );
+        }
+
+        /**
+         * Renders an ActiveEffect's sheet sheet.
+         * @param {PointerEvent} event - The originating click event
+         * @param {HTMLElement} button - The capturing HTML element which defines the [data-action="removeAction"]
+         */
+        static async #editEffect(_event, button) {
+            const effect = this.document.effects.get(button.dataset.effect);
+            effect.sheet.render({ force: true });
+        }
+
+        /**
+         * Delete an ActiveEffect from the item.
+         * @param {PointerEvent} _event - The originating click event
+         * @param {HTMLElement} button - The capturing HTML element which defines the [data-action="removeAction"]
+         */
+        static async #removeEffect(_event, button) {
+            await this.document.effects.get(button.dataset.effect).delete();
+        }
     }
 
     return DHSheetV2;

module/applications/sheets/api/base-item.mjs

@@ -1,6 +1,6 @@
-import DHApplicationMixin from "./application-mixin.mjs";
+import DHApplicationMixin from './application-mixin.mjs';
-import { actionsTypes } from "../../../data/_module.mjs";
+import { actionsTypes } from '../../../data/_module.mjs';
-import DHActionConfig from "../../config/Action.mjs";
+import DHActionConfig from '../../config/Action.mjs';
 
 const { ItemSheetV2 } = foundry.applications.sheets;
 
@@ -29,15 +29,11 @@ export default class DHBaseItemSheet extends DHApplicationMixin(ItemSheetV2) {
     /** @inheritdoc */
     static TABS = {
         primary: {
-      tabs: [
+            tabs: [{ id: 'description' }, { id: 'actions' }, { id: 'settings' }],
-        { id: 'description' },
+            initial: 'description',
-        { id: 'actions' },
+            labelPrefix: 'DAGGERHEART.Sheets.TABS'
-        { id: 'settings' }
-      ],
-      initial: "description",
-      labelPrefix: "DAGGERHEART.Sheets.TABS"
-    }
         }
+    };
 
     /* -------------------------------------------- */
     /*  Application Clicks Actions                  */
@@ -79,7 +75,7 @@ export default class DHBaseItemSheet extends DHApplicationMixin(ItemSheetV2) {
      * @param {HTMLElement} _button - The capturing HTML element which defines the [data-action="addAction"]
      */
     static async #addAction(_event, _button) {
-    const actionType = await DHBaseItemSheet.selectActionType()
+        const actionType = await DHBaseItemSheet.selectActionType();
         try {
             const cls = actionsTypes[actionType?.type] ?? actionsTypes.attack,
                 action = new cls(
@@ -94,7 +90,9 @@ export default class DHBaseItemSheet extends DHApplicationMixin(ItemSheetV2) {
                     }
                 );
             await this.document.update({ 'system.actions': [...this.document.system.actions, action] });
-      await new DHActionConfig(this.document.system.actions[this.document.system.actions.length - 1]).render({force: true});
+            await new DHActionConfig(this.document.system.actions[this.document.system.actions.length - 1]).render({
+                force: true
+            });
         } catch (error) {
             console.log(error);
         }
@@ -102,12 +100,12 @@ export default class DHBaseItemSheet extends DHApplicationMixin(ItemSheetV2) {
 
     /**
      * Edit an existing action on the item
-    * @param {PointerEvent} event - The originating click event
+     * @param {PointerEvent} _event - The originating click event
      * @param {HTMLElement} button - The capturing HTML element which defines the [data-action="editAction"]
      */
     static async #editAction(_event, button) {
         const action = this.document.system.actions[button.dataset.index];
-    await new DHActionConfig(action).render(true);
+        await new DHActionConfig(action).render({ force: true });
     }
 
     /**
@@ -123,5 +121,4 @@ export default class DHBaseItemSheet extends DHApplicationMixin(ItemSheetV2) {
             )
         });
     }
-
 }

module/applications/sheets/api/heritage-sheet.mjs

@@ -0,0 +1,31 @@
+import DHBaseItemSheet from './base-item.mjs';
+
+export default class DHHeritageSheet extends DHBaseItemSheet {
+    /**@inheritdoc */
+    static DEFAULT_OPTIONS = {
+        position: { width: 450, height: 700 }
+    };
+
+    /**@override */
+    static PARTS = {
+        tabs: { template: 'systems/daggerheart/templates/sheets/global/tabs/tab-navigation.hbs' },
+        description: { template: 'systems/daggerheart/templates/sheets/global/tabs/tab-description.hbs' },
+        actions: {
+            template: 'systems/daggerheart/templates/sheets/global/tabs/tab-actions.hbs',
+            scrollable: ['.actions']
+        },
+        effects: {
+            template: 'systems/daggerheart/templates/sheets/global/tabs/tab-effects.hbs',
+            scrollable: ['.effects']
+        }
+    };
+
+    /** @override*/
+    static TABS = {
+        primary: {
+            tabs: [{ id: 'description' }, { id: 'actions' }, { id: 'effects' }],
+            initial: 'description',
+            labelPrefix: 'DAGGERHEART.Sheets.TABS'
+        }
+    };
+}

module/applications/sheets/items/ancestry.mjs

@@ -1,7 +1,6 @@
-import DHHeritageSheetV2 from './heritage.mjs';
+import DHHeritageSheet from '../api/heritage-sheet.mjs';
 
-const { ItemSheetV2 } = foundry.applications.sheets;
+export default class AncestrySheet extends DHHeritageSheet {
-export default class AncestrySheet extends DHHeritageSheetV2(ItemSheetV2) {
     static DEFAULT_OPTIONS = {
         classes: ['ancestry']
     };

module/applications/sheets/items/class.mjs

@@ -50,14 +50,11 @@ export default class ClassSheet extends DHBaseItemSheet {
     /** @inheritdoc */
     static TABS = {
         primary: {
-            tabs: [
+            tabs: [{ id: 'description' }, { id: 'settings' }],
-                { id: 'description' },
+            initial: 'description',
-                { id: 'settings' },
+            labelPrefix: 'DAGGERHEART.Sheets.Feature.Tabs'
-            ],
-            initial: "description",
-            labelPrefix: "DAGGERHEART.Sheets.Feature.Tabs"
-        }
         }
+    };
 
     _attachPartListeners(partId, htmlElement, options) {
         super._attachPartListeners(partId, htmlElement, options);
@@ -72,7 +69,6 @@ export default class ClassSheet extends DHBaseItemSheet {
         return context;
     }
 
-
     onAddTag(e) {
         if (e.detail.index === 2) {
             ui.notifications.info(game.i18n.localize('DAGGERHEART.Notification.Info.ClassCanOnlyHaveTwoDomains'));

module/applications/sheets/items/community.mjs

@@ -1,11 +1,12 @@
-import DHHeritageSheetV2 from './heritage.mjs';
+import DHHeritageSheet from '../api/heritage-sheet.mjs';
 
-const { ItemSheetV2 } = foundry.applications.sheets;
+export default class CommunitySheet extends DHHeritageSheet {
-export default class CommunitySheet extends DHHeritageSheetV2(ItemSheetV2) {
+    /**@inheritdoc */
     static DEFAULT_OPTIONS = {
         classes: ['community']
     };
 
+    /**@inheritdoc */
     static PARTS = {
         header: { template: 'systems/daggerheart/templates/sheets/items/community/header.hbs' },
         ...super.PARTS