From 5cd907573214d89bd67fe5629be7a3d26f04b5f9 Mon Sep 17 00:00:00 2001
From: WBHarry <89362246+WBHarry@users.noreply.github.com>
Date: Sat, 26 Jul 2025 23:30:44 +0200
Subject: [PATCH] Edit option is now always shown on compendium actions (#423)

---
 lang/en.json                                         | 3 ++-
 module/applications/sheets/api/application-mixin.mjs | 2 +-
 module/data/action/baseAction.mjs                    | 2 +-
 templates/sheets-settings/action-settings/base.hbs   | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/lang/en.json b/lang/en.json
index 5d434861..d5a08fff 100755
--- a/lang/en.json
+++ b/lang/en.json
@@ -33,7 +33,8 @@
                     "exact": "Beastform Max Tier",
                     "exactHint": "The Character's Tier is used if empty",
                     "label": "Beastform"
-                }
+                },
+                "displayInChat": "Display in chat"
             },
             "Settings": {
                 "attackBonus": "Attack Bonus",
diff --git a/module/applications/sheets/api/application-mixin.mjs b/module/applications/sheets/api/application-mixin.mjs
index c5c9b46f..b1b335fc 100644
--- a/module/applications/sheets/api/application-mixin.mjs
+++ b/module/applications/sheets/api/application-mixin.mjs
@@ -305,7 +305,7 @@ export default function DHApplicationMixin(Base) {
                     icon: 'fa-solid fa-pen-to-square',
                     condition: target => {
                         const doc = getDocFromElementSync(target);
-                        return doc && (!doc.hasOwnProperty('systemPath') || doc.inCollection);
+                        return !doc || !doc.hasOwnProperty('systemPath') || doc.inCollection;
                     },
                     callback: async target => (await getDocFromElement(target)).sheet.render({ force: true })
                 }
diff --git a/module/data/action/baseAction.mjs b/module/data/action/baseAction.mjs
index 89d0caeb..779e5268 100644
--- a/module/data/action/baseAction.mjs
+++ b/module/data/action/baseAction.mjs
@@ -27,7 +27,7 @@ export default class DHBaseAction extends ActionMixin(foundry.abstract.DataModel
             name: new fields.StringField({ initial: undefined }),
             description: new fields.HTMLField(),
             img: new fields.FilePathField({ initial: undefined, categories: ['IMAGE'], base64: false }),
-            chatDisplay: new fields.BooleanField({ initial: true, label: 'Display in chat' }),
+            chatDisplay: new fields.BooleanField({ initial: true, label: 'DAGGERHEART.ACTIONS.Config.displayInChat' }),
             actionType: new fields.StringField({
                 choices: CONFIG.DH.ITEM.actionTypes,
                 initial: 'action',
diff --git a/templates/sheets-settings/action-settings/base.hbs b/templates/sheets-settings/action-settings/base.hbs
index 4791325d..69b5dfce 100644
--- a/templates/sheets-settings/action-settings/base.hbs
+++ b/templates/sheets-settings/action-settings/base.hbs
@@ -8,7 +8,7 @@
         {{formField fields.name value=source.name label="Name" name="name"}}
         {{formField fields.img value=source.img label="Icon" name="img"}}
         {{formField fields.actionType value=source.actionType label="Type" name="actionType" localize=true}}
-        {{formField fields.chatDisplay value=source.chatDisplay name="chatDisplay" classes="checkbox"}}
+        {{formField fields.chatDisplay value=source.chatDisplay name="chatDisplay" classes="checkbox" localize=true}}
     </fieldset>
     <fieldset class="action-category">
         <legend>{{localize "DAGGERHEART.GENERAL.description"}}</legend>