From 5aa9ba661a33e35a06828ad0f30bcf556b2e2b77 Mon Sep 17 00:00:00 2001
From: WBHarry <89362246+WBHarry@users.noreply.github.com>
Date: Tue, 8 Jul 2025 12:10:38 +0200
Subject: [PATCH] 286 - Adversary Experience Value Bug (#293)

* Changed experience schema field name from 'modifier' to 'total' to match useage in Character and Companion

* Using 'signedString()'
---
 module/applications/sheets/actors/adversary.mjs              | 4 +---
 module/data/actor/adversary.mjs                              | 4 ++--
 templates/sheets-settings/adversary-settings/experiences.hbs | 2 +-
 templates/sheets/actors/adversary/sidebar.hbs                | 2 +-
 4 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/module/applications/sheets/actors/adversary.mjs b/module/applications/sheets/actors/adversary.mjs
index 5dae9741..67f57781 100644
--- a/module/applications/sheets/actors/adversary.mjs
+++ b/module/applications/sheets/actors/adversary.mjs
@@ -92,9 +92,7 @@ export default class AdversarySheet extends DHBaseActorSheet {
             const cls = getDocumentClass('ChatMessage');
             const systemData = {
                 name: game.i18n.localize('DAGGERHEART.GENERAL.Experience.single'),
-                description: `${experience.name} ${
-                    experience.modifier < 0 ? experience.modifier : `+${experience.modifier}`
-                }`
+                description: `${experience.name} ${experience.total.signedString()}`
             };
             const msg = new cls({
                 type: 'abilityUse',
diff --git a/module/data/actor/adversary.mjs b/module/data/actor/adversary.mjs
index 3cbf4eaa..9bb5d5f8 100644
--- a/module/data/actor/adversary.mjs
+++ b/module/data/actor/adversary.mjs
@@ -15,7 +15,7 @@ export default class DhpAdversary extends BaseDataActor {
         return foundry.utils.mergeObject(super.metadata, {
             label: 'TYPES.Actor.adversary',
             type: 'adversary',
-            settingSheet: DHAdversarySettings,
+            settingSheet: DHAdversarySettings
         });
     }
 
@@ -74,7 +74,7 @@ export default class DhpAdversary extends BaseDataActor {
             experiences: new fields.TypedObjectField(
                 new fields.SchemaField({
                     name: new fields.StringField(),
-                    modifier: new fields.NumberField({ required: true, integer: true, initial: 1 })
+                    total: new fields.NumberField({ required: true, integer: true, initial: 1 })
                 })
             ),
             bonuses: new fields.SchemaField({
diff --git a/templates/sheets-settings/adversary-settings/experiences.hbs b/templates/sheets-settings/adversary-settings/experiences.hbs
index fb758a40..c15bf6b9 100644
--- a/templates/sheets-settings/adversary-settings/experiences.hbs
+++ b/templates/sheets-settings/adversary-settings/experiences.hbs
@@ -13,7 +13,7 @@
             {{#each document.system.experiences as |experience key|}}
                 <li class="experience-item">
                     <input class="name" type="text" name="system.experiences.{{key}}.name" value="{{experience.name}}" />
-                    <input class="modifier" type="text" name="system.experiences.{{key}}.modifier" value="{{experience.modifier}}" data-dtype="Number" />
+                    <input class="modifier" type="text" name="system.experiences.{{key}}.total" value="{{experience.total}}" data-dtype="Number" />
                     <a data-action="removeExperience" data-experience="{{key}}" data-tooltip="{{localize 'CONTROLS.CommonDelete'}}"><i class="fa-solid fa-trash"></i></a>
                 </li>
             {{/each}}
diff --git a/templates/sheets/actors/adversary/sidebar.hbs b/templates/sheets/actors/adversary/sidebar.hbs
index 8a410348..b26c1b81 100644
--- a/templates/sheets/actors/adversary/sidebar.hbs
+++ b/templates/sheets/actors/adversary/sidebar.hbs
@@ -94,7 +94,7 @@
             {{#each source.system.experiences as |experience id|}}
                 <div class="experience-row">
                     <div class="experience-value">
-                        +{{experience.modifier}}
+                        +{{experience.total}}
                     </div>
                     <span class="experience-name">{{experience.name}}</span>
                     <div class="controls">