Initial

module/data/action/baseAction.mjs

@@ -376,6 +376,15 @@ export default class DHBaseAction extends ActionMixin(foundry.abstract.DataModel
 
         return tags;
     }
+
+    static migrateData(source) {
+        if (source.damage?.parts && Array.isArray(source.damage.parts)) {
+            source.damage.parts = source.damage.parts.reduce((acc, part) => {
+                acc[part.applyTo] = part;
+                return acc;
+            }, {});
+        }
+    }
 }
 
 export class ResourceUpdateMap extends Map {

module/data/actor/character.mjs

@@ -704,7 +704,7 @@ export default class DhCharacter extends DhCreature {
             isReversed: true
         };
 
-        this.attack.damage.parts[0].value.custom.formula = `@prof${this.basicAttackDamageDice}${this.rules.attack.damage.bonus ? ` + ${this.rules.attack.damage.bonus}` : ''}`;
+        this.attack.damage.parts.hitPoints.value.custom.formula = `@prof${this.basicAttackDamageDice}${this.rules.attack.damage.bonus ? ` + ${this.rules.attack.damage.bonus}` : ''}`;
     }
 
     getRollData() {

module/data/fields/_module.mjs

@@ -1,4 +1,5 @@
 export { ActionCollection } from './actionField.mjs';
+export { default as CollectionField } from './collectionField.mjs';
 export { default as FormulaField } from './formulaField.mjs';
 export { default as ForeignDocumentUUIDField } from './foreignDocumentUUIDField.mjs';
 export { default as ForeignDocumentUUIDArrayField } from './foreignDocumentUUIDArrayField.mjs';

module/data/fields/action/damageField.mjs

@@ -1,5 +1,6 @@
 import FormulaField from '../formulaField.mjs';
 import { setsEqual } from '../../../helpers/utils.mjs';
+import CollectionField from '../collectionField.mjs';
 
 const fields = foundry.data.fields;
 
@@ -12,7 +13,7 @@ export default class DamageField extends fields.SchemaField {
     /** @inheritDoc */
     constructor(options, context = {}) {
         const damageFields = {
-            parts: new fields.ArrayField(new fields.EmbeddedDataField(DHDamageData)),
+            parts: new CollectionField(DHDamageData, { collectionClass: DamagePartsCollection }),
             includeBase: new fields.BooleanField({
                 initial: false,
                 label: 'DAGGERHEART.ACTIONS.Settings.includeBase.label'
@@ -300,3 +301,9 @@ export class DHDamageData extends DHResourceData {
         };
     }
 }
+
+class DamagePartsCollection extends foundry.utils.Collection {
+    get hitPoints() {
+        return this.get('hitPoints');
+    }
+}

module/data/fields/collectionField.mjs

@@ -0,0 +1,25 @@
+export default class CollectionField extends foundry.data.fields.TypedObjectField {
+    constructor(model, options = { collectionClass: foundry.utils.Collection }, context = {}) {
+        super(new foundry.data.fields.EmbeddedDataField(model), options, context);
+        this.#elementClass = model;
+        this.#collectionClass = options.collectionClass;
+    }
+
+    /**
+     * The collection class
+     */
+    #collectionClass;
+
+    /**
+     * The collection element class.
+     */
+    #elementClass;
+
+    initialize(value, model, _options = {}) {
+        console.log(model);
+        const collection = new this.#collectionClass(
+            Object.entries(value).map(([key, value]) => [key, new this.#elementClass(value)])
+        );
+        return collection;
+    }
+}

templates/sheets/items/weapon/settings.hbs

@@ -19,24 +19,24 @@
 
     <fieldset class="two-columns">
         {{#with systemFields.attack.fields.damage.fields.parts.element.fields as | fields | }}
-        {{#with (lookup ../document.system.attack.damage.parts 0) as | source | }}
+        {{#with ../document.system.attack.damage.parts.hitPoints as | source | }}
             <legend>{{localize "DAGGERHEART.GENERAL.damage"}}</legend>
             <span>{{localize "DAGGERHEART.ACTIONS.Config.general.customFormula"}}</span>
-            {{formInput fields.value.fields.custom.fields.enabled value=source.value.custom.enabled name="system.attack.damage.parts.0.value.custom.enabled"}}
+            {{formInput fields.value.fields.custom.fields.enabled value=source.value.custom.enabled name="system.attack.damage.parts.hitPoints.value.custom.enabled"}}
             {{#if source.value.custom.enabled}}
                 <span>{{localize "DAGGERHEART.ACTIONS.Config.general.formula"}}</span>
-                {{formInput fields.value.fields.custom.fields.formula value=source.value.custom.formula name="system.attack.damage.parts.0.value.custom.formula"}}
+                {{formInput fields.value.fields.custom.fields.formula value=source.value.custom.formula name="system.attack.damage.parts.hitPoints.value.custom.formula"}}
             {{else}}
                 <span>{{localize "DAGGERHEART.GENERAL.Dice.single"}}</span>
-                {{formInput fields.value.fields.dice value=source.value.dice name="system.attack.damage.parts.0.value.dice"}}
+                {{formInput fields.value.fields.dice value=source.value.dice name="system.attack.damage.parts.hitPoints.value.dice"}}
                 <span>{{localize "DAGGERHEART.GENERAL.bonus"}}</span>
-                {{formInput fields.value.fields.bonus value=source.value.bonus name="system.attack.damage.parts.0.value.bonus" localize=true}}
+                {{formInput fields.value.fields.bonus value=source.value.bonus name="system.attack.damage.parts.hitPoints.value.bonus" localize=true}}
             {{/if}}
             <span>{{localize "DAGGERHEART.GENERAL.type"}}</span>
-            {{formInput fields.type value=source.type name="system.attack.damage.parts.0.type" localize=true}}
+            {{formInput fields.type value=source.type name="system.attack.damage.parts.hitPoints.type" localize=true}}
             <span>{{localize "DAGGERHEART.CONFIG.DamageType.direct.name"}}</span>
             {{formInput @root.systemFields.attack.fields.damage.fields.direct value=@root.document.system.attack.damage.direct name="system.attack.damage.direct" localize=true}}
-            <input type="hidden" name="system.attack.damage.parts.0.value.multiplier" value="{{source.value.multiplier}}">
+            <input type="hidden" name="system.attack.damage.parts.hitPoints.value.multiplier" value="{{source.value.multiplier}}">
         {{/with}}
         {{/with}}
     </fieldset>