[V14] Refactor ArmorChange schema and fix some bugs (#1742)

* Refactor ArmorChange schema and fix some bugs

* Add current back to schema

* Fixed so changing armor values and taking damage works again

* Fixed so that scrolltexts for armor changes work again

* Removed old marks on armor.system

* Restored damageReductionDialog armorScore.value

* Use toggle for css class addition/removal

* Fix armor change type choices

* Added ArmorChange DamageThresholds

---------

Co-authored-by: WBHarry <williambjrklund@gmail.com>
This commit is contained in:
Carlos Fernandez 2026-03-21 08:53:12 -04:00 committed by GitHub
parent 6193153596
commit 50dcbf4396
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
68 changed files with 356 additions and 428 deletions

View file

@ -94,15 +94,12 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "1",
"armorInteraction": "active"
"interaction": "active"
}
}
]

View file

@ -21,20 +21,21 @@
"flags": {},
"effects": [
{
"name": "Bare Bones Armor",
"name": "Bare Bones",
"type": "base",
"system": {
"changes": [
{
"value": 0,
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"typeData": {
"type": "armor",
"value": {
"max": "3 + @system.traits.strength.value",
"armorInteraction": "inactive"
"interaction": "inactive",
"damageThresholds": {
"major": "9 + (@tier - 1) * 5 + max(0, (@tier -2) * 2 )",
"severe": "19 + (@tier - 1) * 5 + max(0, (@tier -2) * 2 )"
}
}
}
]
@ -62,57 +63,6 @@
"compendiumSource": null
},
"_key": "!items.effects!l5D9kq901JDESaXw.FCsgz7Tdsw6QUzBs"
},
{
"name": "Bare Bones",
"type": "base",
"system": {
"changes": [
{
"key": "system.damageThresholds.major",
"type": "add",
"value": "9 + (@tier - 1) * 5 + max(0, (@tier -2) * 2 )",
"priority": null,
"phase": "initial"
},
{
"key": "system.damageThresholds.severe",
"type": "add",
"value": "19 + (@tier - 1) * 5 + max(0, (@tier -2) * 2 )",
"priority": null,
"phase": "initial"
}
],
"rangeDependence": {
"enabled": false,
"type": "withinRange",
"target": "hostile",
"range": "melee"
}
},
"_id": "8flPpWNoBeuFPFTK",
"img": "icons/magic/control/buff-strength-muscle-damage-orange.webp",
"disabled": false,
"start": null,
"duration": {
"value": null,
"units": "seconds",
"expiry": null,
"expired": false
},
"description": "<p>You use the following as your base damage thresholds:</p><ul><li class=\"vertical-card-list-found\"><p><em><strong>Tier 1:</strong></em> 9/19</p></li><li class=\"vertical-card-list-found\"><p><em><strong>Tier 2:</strong></em> 11/24</p></li><li class=\"vertical-card-list-found\"><p><em><strong>Tier 3:</strong></em> 13/31</p></li><li class=\"vertical-card-list-found\"><p><em><strong>Tier 4:</strong></em> 15/38</p></li></ul>",
"origin": null,
"tint": "#ffffff",
"transfer": true,
"statuses": [],
"showIcon": 1,
"folder": null,
"sort": 0,
"flags": {},
"_stats": {
"compendiumSource": null
},
"_key": "!items.effects!l5D9kq901JDESaXw.8flPpWNoBeuFPFTK"
}
],
"ownership": {

View file

@ -263,13 +263,10 @@
},
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "1"
}
}

View file

@ -95,13 +95,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "1"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -76,13 +76,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -33,13 +33,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -70,13 +70,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -96,13 +96,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "7"
}
}

View file

@ -72,13 +72,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -94,13 +94,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -76,13 +76,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "3"
}
}

View file

@ -87,13 +87,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -76,13 +76,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -33,13 +33,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -83,13 +83,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -33,13 +33,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "3"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "7"
}
}

View file

@ -76,13 +76,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "7"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -33,13 +33,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -71,13 +71,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -63,13 +63,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -70,13 +70,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -70,13 +70,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "4"
}
}

View file

@ -101,13 +101,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "8"
}
}

View file

@ -76,13 +76,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -63,13 +63,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "5"
}
}

View file

@ -63,13 +63,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "6"
}
}

View file

@ -118,13 +118,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier"
}
}

View file

@ -156,13 +156,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier + 1"
}
}

View file

@ -118,13 +118,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier"
}
}

View file

@ -156,13 +156,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier + 1"
}
}

View file

@ -118,13 +118,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier"
}
}

View file

@ -118,13 +118,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier"
}
}

View file

@ -156,13 +156,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier + 1"
}
}

View file

@ -118,13 +118,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier"
}
}

View file

@ -160,13 +160,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "1"
}
}

View file

@ -156,13 +156,10 @@
"system": {
"changes": [
{
"key": "Armor",
"type": "armor",
"phase": "initial",
"priority": 20,
"value": 0,
"typeData": {
"type": "armor",
"value": {
"max": "ITEM.@system.tier + 1"
}
}