cosmo/daggerheart
1
0
Fork 0
mirror of https://github.com/Foundryborne/daggerheart.git synced 2026-06-06 04:44:16 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed so that Homebrew Item Features without effects don't error out because effects are expected

Browse source
This commit is contained in:
WBHarry 2026-04-23 22:51:54 +02:00
parent d73760fc39
commit 41829bc9d5
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
module/applications/sheets-configs/setting-feature-config.mjs
View file

@ -188,8 +188,9 @@ export default class SettingFeatureConfig extends HandlebarsApplicationMixin(App
if (type === 'effect') { if (type === 'effect') {
const move = foundry.utils.getProperty(this.settings, this.movePath); const move = foundry.utils.getProperty(this.settings, this.movePath);
for (const action of move.actions) { for (const action of move.actions) {
const remainingEffects = action.effects.filter(x => x._id !== id); const actionEffects = action.effects ?? [];
if (action.effects.length !== remainingEffects.length) { const remainingEffects = actionEffects.filter(x => x._id !== id);
if (actionEffects.length !== remainingEffects.length) {
await action.update({ await action.update({
effects: remainingEffects.map(x => { effects: remainingEffects.map(x => {
const { _id, ...rest } = x; const { _id, ...rest } = x;

4
module/config/itemConfig.mjs
View file

@ -453,7 +453,7 @@ export const allArmorFeatures = () => {
const feature = homebrewFeatures[key]; const feature = homebrewFeatures[key];
const actions = feature.actions.map(action => ({ const actions = feature.actions.map(action => ({
...action, ...action,
effects: action.effects.map(effect => feature.effects.find(x => x.id === effect._id)), effects: action.effects?.map(effect => feature.effects.find(x => x.id === effect._id))??[],
type: action.type type: action.type
})); }));
const actionEffects = actions.flatMap(a => a.effects); const actionEffects = actions.flatMap(a => a.effects);
@ -1407,7 +1407,7 @@ export const allWeaponFeatures = () => {
const actions = feature.actions.map(action => ({ const actions = feature.actions.map(action => ({
...action, ...action,
effects: action.effects.map(effect => feature.effects.find(x => x.id === effect._id)), effects: action.effects?.map(effect => feature.effects.find(x => x.id === effect._id)) ?? [],
type: action.type type: action.type
})); }));
const actionEffects = actions.flatMap(a => a.effects); const actionEffects = actions.flatMap(a => a.effects);