From 3cdea0c7897bc4c5afeaae029c0ddf50025cecf0 Mon Sep 17 00:00:00 2001
From: Carlos Fernandez <cfern1990@gmail.com>
Date: Mon, 30 Mar 2026 21:15:44 -0400
Subject: [PATCH] Reuse getter in faces setter

---
 module/dice/dualityRoll.mjs | 8 ++++----
 module/dice/fateRoll.mjs    | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/module/dice/dualityRoll.mjs b/module/dice/dualityRoll.mjs
index a6944a56..f4cdeba2 100644
--- a/module/dice/dualityRoll.mjs
+++ b/module/dice/dualityRoll.mjs
@@ -29,8 +29,8 @@ export default class DualityRoll extends D20Roll {
     }
 
     set dHope(faces) {
-        if (!(this.dice[0] instanceof game.system.api.dice.diceTypes.DualityDie)) this.createBaseDice();
-        this.dice[0].faces = this.getFaces(faces);
+        // TODO this should not be asymmetrical with the getter. updateRollConfiguration() should use dHope.faces
+        this.dHope.faces = this.getFaces(faces);
     }
 
     get dFear() {
@@ -39,8 +39,8 @@ export default class DualityRoll extends D20Roll {
     }
 
     set dFear(faces) {
-        if (!(this.dice[1] instanceof game.system.api.dice.diceTypes.DualityDie)) this.createBaseDice();
-        this.dice[1].faces = this.getFaces(faces);
+        // TODO this should not be asymmetrical with the getter. updateRollConfiguration() should use dFear.faces
+        this.dFear.faces = this.getFaces(faces);
     }
 
     get dAdvantage() {
diff --git a/module/dice/fateRoll.mjs b/module/dice/fateRoll.mjs
index 5b52262a..ec03715a 100644
--- a/module/dice/fateRoll.mjs
+++ b/module/dice/fateRoll.mjs
@@ -21,8 +21,8 @@ export default class FateRoll extends D20Roll {
     }
 
     set dHope(faces) {
-        if (!(this.dice[0] instanceof foundry.dice.terms.Die)) this.createBaseDice();
-        this.dice[0].faces = this.getFaces(faces);
+        // TODO this should not be asymmetrical with the getter. updateRollConfiguration() should use dHope.faces
+        this.dHope.faces = this.getFaces(faces);
     }
 
     get dFear() {
@@ -31,8 +31,8 @@ export default class FateRoll extends D20Roll {
     }
 
     set dFear(faces) {
-        if (!(this.dice[0] instanceof foundry.dice.terms.Die)) this.createBaseDice();
-        this.dice[0].faces = this.getFaces(faces);
+        // TODO this should not be asymmetrical with the getter. updateRollConfiguration() should use dFear.faces
+        this.dFear.faces = this.getFaces(faces);
     }
 
     get isCritical() {