cosmo/daggerheart
1
0
Fork 0
mirror of https://github.com/Foundryborne/daggerheart.git synced 2026-01-17 15:39:02 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Extract method for repeated calculation.

Browse source 
In the downtime dialog, we need to calculate the number of selected moves in
several places. This commit extracts a method to handle that, which reduces
repetition and hopefully makes the code more readable.
This commit is contained in:
George Brocklehurst 2025-07-20 10:35:06 +01:00
parent 26d412815a
commit 343ee4978b
No known key found for this signature in database
GPG key ID: 0C643A97B51FFCFB
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
module/applications/dialogs/downtime.mjs
View file

@ -64,14 +64,8 @@ export default class DhpDowntime extends HandlebarsApplicationMixin(ApplicationV
context.selectedActivity = this.selectedActivity; context.selectedActivity = this.selectedActivity;
context.moveData = this.moveData; context.moveData = this.moveData;
const shortRestMovesSelected = Object.values(this.moveData.shortRest.moves).reduce( const shortRestMovesSelected = this.#nrSelectedMoves('shortRest');
(acc, x) => acc + (x.selected ?? 0), const longRestMovesSelected = this.#nrSelectedMoves('longRest');
0
);
const longRestMovesSelected = Object.values(this.moveData.longRest.moves).reduce(
(acc, x) => acc + (x.selected ?? 0),
0
);
context.nrChoices = { context.nrChoices = {
...this.nrChoices, ...this.nrChoices,
shortRest: { shortRest: {
@ -95,7 +89,7 @@ export default class DhpDowntime extends HandlebarsApplicationMixin(ApplicationV
static selectMove(_, target) { static selectMove(_, target) {
const { category, move } = target.dataset; const { category, move } = target.dataset;
const nrSelected = Object.values(this.moveData[category].moves).reduce((acc, x) => acc + (x.selected ?? 0), 0); const nrSelected = this.#nrSelectedMoves(category);
if (nrSelected + this.nrChoices[category].taken >= this.nrChoices[category].max) { if (nrSelected + this.nrChoices[category].taken >= this.nrChoices[category].max) {
ui.notifications.error(game.i18n.localize('DAGGERHEART.UI.Notifications.noMoreMoves')); ui.notifications.error(game.i18n.localize('DAGGERHEART.UI.Notifications.noMoreMoves'));
@ -181,4 +175,8 @@ export default class DhpDowntime extends HandlebarsApplicationMixin(ApplicationV
this.customActivity = foundry.utils.mergeObject(this.customActivity, formData.object); this.customActivity = foundry.utils.mergeObject(this.customActivity, formData.object);
this.render(); this.render();
} }
#nrSelectedMoves(category) {
return Object.values(this.moveData[category].moves).reduce((acc, x) => acc + (x.selected ?? 0), 0);
}
} }