From 2d20fb0df447ba50fbe8b545f6f0a6c736489407 Mon Sep 17 00:00:00 2001
From: WBHarry <williambjrklund@gmail.com>
Date: Sat, 23 Aug 2025 13:18:14 +0200
Subject: [PATCH] Fixed multiclass

---
 module/data/actor/character.mjs | 5 +++--
 module/data/item/base.mjs       | 4 ++--
 module/data/item/class.mjs      | 9 ---------
 module/data/item/feature.mjs    | 1 +
 module/documents/actor.mjs      | 4 ++--
 5 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/module/data/actor/character.mjs b/module/data/actor/character.mjs
index 7dd7993c..7ddd878c 100644
--- a/module/data/actor/character.mjs
+++ b/module/data/actor/character.mjs
@@ -317,7 +317,7 @@ export default class DhCharacter extends BaseDataActor {
     }
 
     get multiclass() {
-        const value = this.parent.items.find(x => x.type === 'Class' && x.system.isMulticlass);
+        const value = this.parent.items.find(x => x.type === 'class' && x.system.isMulticlass);
         const subclass = this.parent.items.find(x => x.type === 'subclass' && x.system.isMulticlass);
 
         return {
@@ -443,7 +443,8 @@ export default class DhCharacter extends BaseDataActor {
                 classFeatures.push(item);
             } else if (item.system.originItemType === CONFIG.DH.ITEM.featureTypes.subclass.id) {
                 if (this.class.subclass) {
-                    const subclassState = this.class.subclass.system.featureState;
+                    const prop = item.system.multiclassOrigin ? 'multiclass' : 'class';
+                    const subclassState = this[prop].subclass.system.featureState;
 
                     if (
                         item.system.identifier === CONFIG.DH.ITEM.featureSubTypes.foundation ||
diff --git a/module/data/item/base.mjs b/module/data/item/base.mjs
index f333537b..f8eae265 100644
--- a/module/data/item/base.mjs
+++ b/module/data/item/base.mjs
@@ -148,7 +148,6 @@ export default class BaseDataItem extends foundry.abstract.TypeDataModel {
             for (let f of this.features) {
                 const fBase = f.item ?? f;
                 const feature = fBase.system ? fBase : await foundry.utils.fromUuid(fBase.uuid);
-                const multiclass = this.isMulticlass ? 'multiclass' : null;
                 features.push(
                     foundry.utils.mergeObject(
                         feature.toObject(),
@@ -156,7 +155,8 @@ export default class BaseDataItem extends foundry.abstract.TypeDataModel {
                             _stats: { compendiumSource: fBase.uuid },
                             system: {
                                 originItemType: this.parent.type,
-                                identifier: multiclass ?? (f.item ? f.type : null)
+                                identifier: f.item ? f.type : null,
+                                multiclassOrigin: this.isMulticlass
                             }
                         },
                         { inplace: false }
diff --git a/module/data/item/class.mjs b/module/data/item/class.mjs
index 5e92d2fc..157f70c5 100644
--- a/module/data/item/class.mjs
+++ b/module/data/item/class.mjs
@@ -102,15 +102,6 @@ export default class DHClass extends BaseDataItem {
         if (allowed === false) return;
     }
 
-    _onDelete(options, userId) {
-        super._onDelete(options, userId);
-
-        if (options.parent?.type === 'character') {
-            const path = `system.${this.isMulticlass ? 'multiclass' : 'class'}`;
-            foundry.utils.getProperty(options.parent, `${path}.subclass`)?.delete();
-        }
-    }
-
     async _preUpdate(changed, options, userId) {
         const allowed = await super._preUpdate(changed, options, userId);
         if (allowed === false) return false;
diff --git a/module/data/item/feature.mjs b/module/data/item/feature.mjs
index 6e1aab41..3b8fe064 100644
--- a/module/data/item/feature.mjs
+++ b/module/data/item/feature.mjs
@@ -29,6 +29,7 @@ export default class DHFeature extends BaseDataItem {
                 nullable: true,
                 initial: null
             }),
+            multiclassOrigin: new fields.BooleanField({ initial: false }),
             identifier: new fields.StringField()
         };
     }
diff --git a/module/documents/actor.mjs b/module/documents/actor.mjs
index e1dd93af..3325547c 100644
--- a/module/documents/actor.mjs
+++ b/module/documents/actor.mjs
@@ -164,10 +164,10 @@ export default class DhpActor extends Actor {
                 if (multiclass) {
                     const multiclassItem = this.items.find(x => x.uuid === multiclass.itemUuid);
                     const multiclassFeatures = this.items.filter(
-                        x => x.system.originItemType === 'class' && x.system.identifier === 'multiclass'
+                        x => x.system.originItemType === 'class' && x.system.multiclassOrigin
                     );
                     const subclassFeatures = this.items.filter(
-                        x => x.system.originItemType === 'subclass' && x.system.identifier === 'multiclass'
+                        x => x.system.originItemType === 'subclass' && x.system.multiclassOrigin
                     );
 
                     this.deleteEmbeddedDocuments(