From 0e8dd59b4b72e43411a635775cf5d4bea08e601b Mon Sep 17 00:00:00 2001
From: Joaquin Pereyra <joaquinpereyra98@users.noreply.github.com>
Date: Sat, 19 Jul 2025 17:12:18 -0300
Subject: [PATCH] FIX: remove default list styles FIX: .extended css reduce
 max-height, shorten animation duration to 0.5s, and set overflow to auto.
 FIX: set enriched=notes.enriche on notes.hbs FIX: set experience.value on
 sidebar.hbs FIX: move tooltip from item-img to img-portrait on
 inventory-item-V2.hbs REMOVE: unused files

---
 module/systemRegistration/handlebars.mjs      |   2 -
 styles/less/global/inventory-item.less        |  10 +-
 templates/sheets/actors/adversary/notes.hbs   |   2 +-
 templates/sheets/actors/adversary/sidebar.hbs |   2 +-
 .../partials/inventory-fieldset-items.hbs     |  44 ----
 .../global/partials/inventory-item-V2.hbs     |   8 +-
 .../sheets/global/partials/inventory-item.hbs | 197 ------------------
 7 files changed, 13 insertions(+), 252 deletions(-)
 delete mode 100644 templates/sheets/global/partials/inventory-fieldset-items.hbs
 delete mode 100644 templates/sheets/global/partials/inventory-item.hbs

diff --git a/module/systemRegistration/handlebars.mjs b/module/systemRegistration/handlebars.mjs
index 15f095da..ec5f2df1 100644
--- a/module/systemRegistration/handlebars.mjs
+++ b/module/systemRegistration/handlebars.mjs
@@ -5,10 +5,8 @@ export const preloadHandlebarsTemplates = async function () {
     })
     return foundry.applications.handlebars.loadTemplates([
         'systems/daggerheart/templates/sheets/global/tabs/tab-navigation.hbs',
-        'systems/daggerheart/templates/sheets/global/partials/inventory-item.hbs',
         'systems/daggerheart/templates/sheets/global/partials/action-item.hbs',
         'systems/daggerheart/templates/sheets/global/partials/domain-card-item.hbs',
-        'systems/daggerheart/templates/sheets/global/partials/inventory-fieldset-items.hbs',
         'systems/daggerheart/templates/sheets/global/partials/item-resource.hbs',
         'systems/daggerheart/templates/sheets/global/partials/resource-section.hbs',
         'systems/daggerheart/templates/components/card-preview.hbs',
diff --git a/styles/less/global/inventory-item.less b/styles/less/global/inventory-item.less
index 1775be24..d758085b 100644
--- a/styles/less/global/inventory-item.less
+++ b/styles/less/global/inventory-item.less
@@ -21,6 +21,7 @@
 .application.daggerheart.dh-style {
     .inventory-item {
         width: 100%;
+        list-style-type: none;
 
         &:hover {
             .inventory-item-header .img-portait {
@@ -108,13 +109,16 @@
         }
 
         .inventory-item-content {
+            > *:not(:last-child) {
+                margin-bottom: 5px;
+            }
             &.extensible {
                 max-height: 0;
                 overflow: hidden;
-                transition: max-height 2s linear;
+                transition: max-height 0.5s ease-in-out;
                 &.extended {
-                    max-height: 1000px; // Reasonable large value
-                    //maybe need the redo this.... idk, i'm just a little wittle girl, atte: JP.
+                    max-height: 500px;
+                    overflow: auto;
                 }
             }
             .item-resources {
diff --git a/templates/sheets/actors/adversary/notes.hbs b/templates/sheets/actors/adversary/notes.hbs
index 663a484a..a2378516 100644
--- a/templates/sheets/actors/adversary/notes.hbs
+++ b/templates/sheets/actors/adversary/notes.hbs
@@ -5,6 +5,6 @@
 >
     <fieldset class="fit-height">
         <legend>{{localize tabs.notes.label}}</legend>
-        {{formInput notes.field value=notes.value enriched=notes.value toggled=true}}
+        {{formInput notes.field value=notes.value enriched=notes.enriched toggled=true}}
     </fieldset>
 </section>
\ No newline at end of file
diff --git a/templates/sheets/actors/adversary/sidebar.hbs b/templates/sheets/actors/adversary/sidebar.hbs
index dabbbffe..8eb4dcb0 100644
--- a/templates/sheets/actors/adversary/sidebar.hbs
+++ b/templates/sheets/actors/adversary/sidebar.hbs
@@ -99,7 +99,7 @@
             {{#each source.system.experiences as |experience id|}}
             <div class="experience-row">
                 <div class="experience-value">
-                    +{{experience.total}}
+                    +{{experience.value}}
                 </div>
                 <span class="experience-name">{{experience.name}}</span>
                 <div class="controls">
diff --git a/templates/sheets/global/partials/inventory-fieldset-items.hbs b/templates/sheets/global/partials/inventory-fieldset-items.hbs
deleted file mode 100644
index 65c52736..00000000
--- a/templates/sheets/global/partials/inventory-fieldset-items.hbs
+++ /dev/null
@@ -1,44 +0,0 @@
-<fieldset class="{{#if isGlassy}}glassy{{/if}}">
-    <legend>{{title}}</legend>
-    <ul class="items-list">
-        {{#unless (eq cardView 'card') }}
-            {{#if (or (eq type 'domainCard') (eq type 'armor') (eq type 'consumable') (eq type 'miscellaneous') (eq type 'weapon'))}}
-                {{#each document.items as |item|}}
-                    {{#if (eq item.type ../type)}}
-                        {{#unless (and (eq ../type 'domainCard') (or (and item.system.inVault (not ../isVault)) (and (not item.system.inVault) ../isVault)))}}
-                            {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-item.hbs' item=item type=../type}}
-                        {{/unless}}
-                    {{/if}}
-                {{/each}}
-            {{else}}
-                {{#if (eq type 'effect')}}
-                    {{#each document.effects as |effect|}}
-                        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-item.hbs' item=effect type=../type}}
-                    {{/each}}
-                {{else}}
-                    {{#each values}}
-                        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-item.hbs' item=this type=../type hideControls=../hideControls featureType=true }}
-                    {{/each}}
-                    
-                    {{#each adversaries as |adversary|}}
-                        {{> 'systems/daggerheart/templates/sheets/global/partials/inventory-item.hbs' item=adversary type='adversary' hideControls=true isActor=true categoryAdversary=@../key}}
-                    {{/each}}
-                {{/if}}
-            {{/if}}
-        {{/unless}}
-        
-    </ul>
-    {{#if (and (eq cardView 'card') (eq type 'domainCard'))}}
-        <ul class="card-list">
-            {{#if isVault}}
-                {{#each document.system.domainCards.vault as |card|}}
-                    {{> 'systems/daggerheart/templates/sheets/global/partials/domain-card-item.hbs' item=card type=../type}}
-                {{/each}}
-            {{else}}
-                {{#each document.system.domainCards.loadout as |card|}}
-                    {{> 'systems/daggerheart/templates/sheets/global/partials/domain-card-item.hbs' item=card type=../type}}
-                {{/each}}
-            {{/if}}
-        </ul>
-    {{/if}}
-</fieldset>
\ No newline at end of file
diff --git a/templates/sheets/global/partials/inventory-item-V2.hbs b/templates/sheets/global/partials/inventory-item-V2.hbs
index ecb017d6..5329e7b5 100644
--- a/templates/sheets/global/partials/inventory-item-V2.hbs
+++ b/templates/sheets/global/partials/inventory-item-V2.hbs
@@ -20,10 +20,10 @@ Parameters:
   <div class="inventory-item-header" {{#unless noExtensible}}data-action="toggleExtended" {{/unless}}>
     {{!-- Image --}}
     <div class="img-portait"
-      data-action='{{ifThen (hasProperty item "use") "useItem" (ifThen (hasProperty item "toChat") "toChat" "editDoc") }}'>
-      <img src="{{item.img}}" class="item-img {{#if isActor}}actor-img{{/if}}" {{#unless
-        hideTooltip}}data-tooltip="#item#{{item.uuid}}" {{/unless}} />
-      <img class="roll-img" src="systems/daggerheart/assets/icons/dice/default/d20.svg" alt="">
+      data-action='{{ifThen (hasProperty item "use") "useItem" (ifThen (hasProperty item "toChat") "toChat" "editDoc") }}'
+      {{#unless hideTooltip}}data-tooltip="#item#{{item.uuid}}" {{/unless}}>
+      <img src="{{item.img}}" class="item-img {{#if isActor}}actor-img{{/if}}" />
+      <img class="roll-img" src="systems/daggerheart/assets/icons/dice/default/d20.svg" alt="d20">
     </div>
 
     {{!-- Name & Tags --}}
diff --git a/templates/sheets/global/partials/inventory-item.hbs b/templates/sheets/global/partials/inventory-item.hbs
deleted file mode 100644
index a6373c08..00000000
--- a/templates/sheets/global/partials/inventory-item.hbs
+++ /dev/null
@@ -1,197 +0,0 @@
-<li class="inventory-item" data-item-id="{{item.id}}" data-item-uuid="{{item.uuid}}" data-type="{{type}}" draggable="true">
-    <img src="{{item.img}}" class="item-img {{#if isActor}}actor-img{{/if}}" data-action="useItem" {{#if (not noTooltip)}}data-tooltip="{{concat "#item#" item.uuid}}"{{/if}} />
-    <div class="item-label-wrapper">
-        <div class="item-label {{#unless (and (not isSidebar) (or (eq item.system.resource.type 'simple') item.system.quantity))}}fullWidth{{/unless}}">
-            {{#if isCompanion}}
-                <a class="item-name" data-action="attackRoll">{{item.name}}</a>
-            {{else}}
-                <div class="item-name">{{item.name}}</div>
-            {{/if}}
-            {{#if  (eq type 'weapon')}} 
-                <div class="item-tags">
-                    {{#if isSidebar}}
-                        <div class="item-labels">
-                            <div class="label">
-                                {{localize (concat 'DAGGERHEART.CONFIG.Traits.' item.system.attack.roll.trait '.short')}}
-                                {{localize (concat 'DAGGERHEART.CONFIG.Range.' item.system.attack.range '.short')}}
-                                <span> - </span>
-                                {{item.system.attack.damage.parts.0.value.dice}}{{#if item.system.attack.damage.parts.0.value.bonus}} + {{item.system.attack.damage.parts.0.value.bonus}}{{/if}}
-                                {{#each item.system.attack.damage.parts.0.type as | type | }}
-                                    {{#with (lookup @root.config.GENERAL.damageTypes type)}}
-                                        <i class="fa-solid {{icon}}"></i>
-                                    {{/with}}
-                                {{/each}}
-                            </div>
-                        </div>
-                    {{else}}
-                        <div class="tag">
-                            {{localize (concat 'DAGGERHEART.CONFIG.Traits.' item.system.attack.roll.trait '.name')}}
-                        </div>
-                        <div class="tag">
-                            {{localize (concat 'DAGGERHEART.CONFIG.Range.' item.system.attack.range '.name')}}
-                        </div>
-                        <div class="tag">
-                            {{item.system.attack.damage.parts.0.value.dice}}{{#if item.system.attack.damage.parts.0.value.bonus}} + {{item.system.attack.damage.parts.0.value.bonus}}{{/if}}
-                            (
-                                {{#each item.system.attack.damage.parts.0.type}}
-                                    {{localize (concat 'DAGGERHEART.CONFIG.DamageType.' this '.abbreviation')}}
-                                {{/each}}
-                            )
-                        </div>
-                        <div class="tag">
-                            {{localize (concat 'DAGGERHEART.CONFIG.Burden.' item.system.burden)}}
-                        </div>
-                    {{/if}}
-                </div>
-            {{/if}}
-            {{#if  (eq type 'armor')}}
-                {{#if isSidebar}}
-                    <div class="item-labels">
-                        <div class="label">
-                            {{localize "DAGGERHEART.ITEMS.Armor.baseScore"}}:
-                            {{item.system.baseScore}}
-                        </div>
-                    </div>
-                {{else}}
-                    <div class="item-tags">
-                        <div class="tag">
-                            {{localize "DAGGERHEART.ITEMS.Armor.baseScore"}}:
-                            {{item.system.baseScore}}
-                        </div>
-                        <div class="tag">
-                            {{localize "DAGGERHEART.ITEMS.Armor.baseThresholds.base"}}:
-                            {{item.system.baseThresholds.major}}
-                            <span>/</span>
-                            {{item.system.baseThresholds.severe}}
-                        </div>
-                    </div>
-                {{/if}}
-            {{/if}}
-            {{#if  (eq type 'domainCard')}}
-                {{#if isSidebar}}
-                    <div class="item-labels">
-                        <div class="label">
-                            {{localize (concat 'DAGGERHEART.CONFIG.DomainCardTypes.' item.system.type)}}
-                            <span> - </span>
-                            {{localize (concat 'DAGGERHEART.GENERAL.Domain.' item.system.domain '.label')}}
-                            <span> - </span>
-                            <span class="recall-value">{{item.system.recallCost}}</span>
-                            <i class="fa-solid fa-bolt"></i>
-                        </div>
-                    </div>
-                {{else}}
-                    <div class="item-tags">
-                        <div class="tag">
-                            {{localize (concat 'DAGGERHEART.CONFIG.DomainCardTypes.' item.system.type)}}
-                        </div>
-                        <div class="tag">
-                            {{localize (concat 'DAGGERHEART.GENERAL.Domain.' item.system.domain '.label')}}
-                        </div>
-                        <div class="tag">
-                            <span class="recall-label">{{localize "DAGGERHEART.ITEMS.DomainCard.recallCost"}}: </span>
-                            <span class="recall-value">{{item.system.recallCost}}</span>
-                        </div>
-                    </div>
-                {{/if}}
-            {{/if}}
-            {{#if  (eq type 'effect')}}
-                <div class="item-tags">
-                    <div class="tag">
-                        {{localize (concat 'TYPES.Item.' item.parent.type)}}
-                        <span>: </span>
-                        {{item.parent.name}}
-                    </div>
-                    <div class="tag">
-                        {{#if item.duration.duration}}
-                            {{localize 'DAGGERHEART.EFFECTS.Duration.temporary'}}
-                        {{else}}
-                            {{localize 'DAGGERHEART.EFFECTS.Duration.passive'}}
-                        {{/if}}
-                    </div>
-                    {{#each item.statuses as |status|}}
-                        <div class="tag">
-                            {{localize (concat 'DAGGERHEART.CONFIG.Condition.' status '.name')}}
-                        </div>
-                    {{/each}}
-                </div>
-            {{/if}}
-            {{#if  (eq type 'action')}}
-                <div class="item-tags">
-                    <div class="tag">
-                        {{localize (concat 'DAGGERHEART.ACTIONS.TYPES.' item.type '.name')}}
-                    </div>
-                    <div class="tag">
-                        {{localize (concat 'DAGGERHEART.CONFIG.ActionType.' item.actionType)}}
-                    </div>
-                </div>
-            {{/if}}
-        </div>
-        {{#if (and (not isSidebar) (eq item.system.resource.type 'simple'))}}
-            {{> "systems/daggerheart/templates/sheets/global/partials/item-resource.hbs"}}
-        {{/if}}
-        {{#if (and (not isSidebar) item.system.quantity)}}
-            <div class="item-resource">
-                <input type="number" class="inventory-item-quantity" value="{{item.system.quantity}}" step="1" />
-            </div>
-        {{/if}}
-    </div>
-    {{#unless hideControls}}
-        {{#if isActor}}
-            <div class="controls">
-                {{#if (eq type 'actor')}}
-                    <a data-action="viewActor" data-potential-adversary="{{categoryAdversary}}" data-adversary="{{item.uuid}}" data-tooltip='{{localize "DAGGERHEART.UI.Tooltip.openActorWorld"}}'>
-                        <i class="fa-solid fa-globe"></i>
-                    </a>
-                {{/if}}
-                {{#if (eq type 'adversary')}}
-                    <a data-action="viewAdversary" data-potential-adversary="{{categoryAdversary}}" data-adversary="{{item.uuid}}" data-tooltip='{{localize "DAGGERHEART.UI.Tooltip.openActorWorld"}}'>
-                        <i class="fa-solid fa-globe"></i>
-                    </a>
-                    <a data-action='deleteAdversary' data-potential-adversary="{{categoryAdversary}}" data-adversary="{{item.uuid}}" data-tooltip='{{localize "CONTROLS.CommonDelete"}}'>
-                        <i class='fas fa-trash'></i>
-                    </a>
-                {{/if}}
-            </div>
-        {{else}}
-            <div class="controls">
-                {{#if (eq type 'weapon')}}
-                    <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'DAGGERHEART.UI.Tooltip.equip'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
-                        <i class="fa-solid fa-hands"></i>
-                    </a>
-                {{/if}}
-                {{#if (eq type 'armor')}}
-                    <a class="{{#unless item.system.equipped}}unequipped{{/unless}}" data-action="toggleEquipItem" data-tooltip="{{#unless item.system.equipped}}{{localize 'DAGGERHEART.UI.Tooltip.equip'}}{{else}}{{localize 'DAGGERHEART.UI.Tooltip.unequip'}}{{/unless}}">
-                    <i class="fa-solid fa-shield"></i>
-                    </a>
-                {{/if}}
-                {{#if (eq type 'domainCard')}}
-                    {{#unless item.system.inVault}}
-                        <a data-action="toggleVault" data-tooltip="{{localize 'DAGGERHEART.UI.Tooltip.sendToVault'}}">
-                            <i class="fa-solid fa-arrow-down"></i>
-                        </a>
-                    {{else}}
-                        <a data-action="toggleVault" data-tooltip="{{localize 'DAGGERHEART.UI.Tooltip.sendToLoadout'}}">
-                            <i class="fa-solid fa-arrow-up"></i>
-                        </a>
-                    {{/unless}}
-                    
-                {{/if}}
-                <a data-action="toChat" data-tooltip="{{localize 'DAGGERHEART.UI.Tooltip.sendToChat'}}"><i class="fa-regular fa-message"></i></a>
-                <a data-action="triggerContextMenu" data-tooltip="{{localize 'DAGGERHEART.UI.Tooltip.moreOptions'}}"><i class="fa-solid fa-ellipsis-vertical"></i></a>
-            </div>
-        {{/if}}
-    {{else}}
-        <span></span>
-    {{/unless}}
-    <div class="item-description">{{#unless isSidebar}}{{{item.system.description}}}{{/unless}}</div>
-    {{#if (and (not isSidebar) (eq item.system.resource.type 'diceValue'))}}
-        {{> "systems/daggerheart/templates/sheets/global/partials/item-resource.hbs"}}
-    {{/if}}
-    {{#if featureType}}
-        <div class="item-buttons">
-            {{#each item.system.actions as | action |}}
-                <button type="button" data-action="useAction" data-action-id="{{action.id}}">{{action.name}}</button>
-            {{/each}}
-        </div>
-    {{/if}}
-</li>
\ No newline at end of file